Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

_sign_string private_key_file can now be file-like #1349

Merged
merged 1 commit into from Jul 23, 2013

Conversation

Projects
None yet
2 participants
Contributor

seandst commented Feb 23, 2013

Distribution._sign_string is now a little bit more flexible, allowing
the private_key_file to be a file-like object (or really anything with a
.read() method).

My experiments in the world of signed cloudfront URLs were being impeded by the inability to pass file-like objects through _sign_string. This builds on the unit tests I wrote a little bit ago (#1271), and I'm pretty confident that it's backward compatible.

Test included.

@seandst seandst _sign_string private_key_file can now be file-like
Distribution._sign_string is now a little bit more flexible, allowing
the private_key_file to be a file-like object (or really anything with a
.read() method).
ba8417f

@ghost ghost assigned toastdriven Jul 16, 2013

@toastdriven toastdriven merged commit ba8417f into boto:develop Jul 23, 2013

Contributor

toastdriven commented Jul 23, 2013

Thanks! Merged.

@toastdriven toastdriven removed their assignment Mar 31, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment