Extended Vault.concurrent_create_archive_from_file function. #1380

wants to merge 1 commit into

3 participants


Added part_size and num_threads arguments to Vault.concurrent_create_archive_from_file as well as a constant for default number of worker threads.


+1. My only question is if the docs generate correctly with these updates or if more work is required.

the boto project member

Not opposed to this, but my concern is that this will essentially have to stay in sync with ConcurrentUploader.__init__. Wondering if it makes more sense to just do something simliar to create_archive_writer and return a ConcurrentUploader object. We could then just forward *args, **kwargs to ConcurrentUploader.__init__. Thoughts?

the boto project member

Closing in favor of #1420, which forwards **kwargs through. I plan on adding some additional args to the ConcurrentUploader shortly and this way concurrent_create_archive_from_file won't have to be updated.

@jamesls jamesls closed this Apr 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment