Skip to content

Fix use of STS generated auth key + tokens with SWF #1871

Open
wants to merge 1 commit into from

2 participants

@katzj
katzj commented Nov 25, 2013

Be explicit about what the security token is. Note that this does change the parameter name but it couldn't ever have worked before since passing the token as an unnamed parameter meant it was being used as https_connection_factory.

I can make both parameter names work but it felt like cruft since it couldn't have worked before.

@katzj katzj Fix use of STS generated auth key + tokens with SWF
Be explicit about what the security token is.  Note that this
does change the parameter name but it couldn't ever have worked
before since passing the token as an unnamed parameter meant it
was being used as https_connection_factory
aaefce1
@danielgtaylor
the boto project member

Wow, thanks for finding and fixing this. Can you please add a unit test that makes sure the proper value is assigned after instantiating the class? That will help prevent errors like this in the future. Thanks!

@katzj
katzj commented Nov 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.