Fix use of STS generated auth key + tokens with SWF #1871

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@katzj
Contributor

katzj commented Nov 25, 2013

Be explicit about what the security token is. Note that this does change the parameter name but it couldn't ever have worked before since passing the token as an unnamed parameter meant it was being used as https_connection_factory.

I can make both parameter names work but it felt like cruft since it couldn't have worked before.

Fix use of STS generated auth key + tokens with SWF
Be explicit about what the security token is.  Note that this
does change the parameter name but it couldn't ever have worked
before since passing the token as an unnamed parameter meant it
was being used as https_connection_factory
@danielgtaylor

This comment has been minimized.

Show comment
Hide comment
@danielgtaylor

danielgtaylor Nov 25, 2013

Member

Wow, thanks for finding and fixing this. Can you please add a unit test that makes sure the proper value is assigned after instantiating the class? That will help prevent errors like this in the future. Thanks!

Member

danielgtaylor commented Nov 25, 2013

Wow, thanks for finding and fixing this. Can you please add a unit test that makes sure the proper value is assigned after instantiating the class? That will help prevent errors like this in the future. Thanks!

@katzj

This comment has been minimized.

Show comment
Hide comment
@katzj

katzj Nov 25, 2013

Contributor

No problem. We hit all the corner cases here ;)

And I'll knock out a test for it tonight. Tests in boto are a new (but
good) thing

On Mon, Nov 25, 2013 at 4:34 PM, Daniel G. Taylor
notifications@github.comwrote:

Wow, thanks for finding and fixing this. Can you please add a unit test
that makes sure the proper value is assigned after instantiating the class?
That will help prevent errors like this in the future. Thanks!


Reply to this email directly or view it on GitHubhttps://github.com/boto/boto/pull/1871#issuecomment-29244454
.

Contributor

katzj commented Nov 25, 2013

No problem. We hit all the corner cases here ;)

And I'll knock out a test for it tonight. Tests in boto are a new (but
good) thing

On Mon, Nov 25, 2013 at 4:34 PM, Daniel G. Taylor
notifications@github.comwrote:

Wow, thanks for finding and fixing this. Can you please add a unit test
that makes sure the proper value is assigned after instantiating the class?
That will help prevent errors like this in the future. Thanks!


Reply to this email directly or view it on GitHubhttps://github.com/boto/boto/pull/1871#issuecomment-29244454
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment