Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Quick solution to issue 1874. #1893
Make AssociateAddress return an object with the Association ID instead of a boolean status.
I'm not sure how intrusive a change this would be for the regular/supported use cases of Boto. Anyone who depends on the boolean response will need to change their expected return values.
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
Unfortunately this is not a backwards-compatible change. Since we don't want to break existing users I think a better approach would be to copy this method, apply your change and give it a new name. It means that we now have two methods that do the same exact call, which is kind of ugly, but it means the code remains backwards compatible and people who want the feature can opt-in by calling the new method.
I might suggest a name like
Edit: I'll also mention that we need to add a unit test to make sure the correct object with the correct fields is returned.