New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security_token parameter to STSConnection #1931

Merged
merged 1 commit into from Dec 23, 2013

Conversation

Projects
None yet
2 participants
@jimbrowne
Contributor

jimbrowne commented Dec 19, 2013

Add the security_token parameter to STS so one can use temporary credentials to make STS calls.

@danielgtaylor

This comment has been minimized.

Show comment
Hide comment
@danielgtaylor

danielgtaylor Dec 20, 2013

Member

@jimbrowne this change looks great, however can you please add a quick unit test to ensure the parameter gets passed through properly? Once that's there I can merge it in!

Member

danielgtaylor commented Dec 20, 2013

@jimbrowne this change looks great, however can you please add a quick unit test to ensure the parameter gets passed through properly? Once that's there I can merge it in!

@ghost ghost assigned danielgtaylor Dec 20, 2013

@jimbrowne

This comment has been minimized.

Show comment
Hide comment
@jimbrowne

jimbrowne Dec 22, 2013

Contributor

It is unclear to me if the test should instead be a modification of AWSMockServiceTestCase rather than an STS specific test. It seems to me for an STS test I'll wind up having to override all of AWSMockServiceTestCase.setup

Contributor

jimbrowne commented Dec 22, 2013

It is unclear to me if the test should instead be a modification of AWSMockServiceTestCase rather than an STS specific test. It seems to me for an STS test I'll wind up having to override all of AWSMockServiceTestCase.setup

@danielgtaylor

This comment has been minimized.

Show comment
Hide comment
@danielgtaylor

danielgtaylor Dec 23, 2013

Member

I've added a quick test to the pull request above. It was a bit more complicated than I initially suspected, so no worries!

Member

danielgtaylor commented Dec 23, 2013

I've added a quick test to the pull request above. It was a bit more complicated than I initially suspected, so no worries!

danielgtaylor added a commit that referenced this pull request Dec 23, 2013

Merge pull request #1948 from danielgtaylor/jimbrowne-sts-secure-token
Pass security token through to STS connection. Fixes #1948, #1931.

@danielgtaylor danielgtaylor merged commit 52bffd9 into boto:develop Dec 23, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment