Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add GetSubscriptionAttributes support to SNS #1982

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

Simple addition of a get_subscription_attributes method in boto.sns to access the GetSubscriptionAttributes API. It is copied almost directly from the existing get_endpoint_attributes method.

Owner

danielgtaylor commented Jan 20, 2014

This looks good, but needs a unit test to be merged. Please add a test (see tests/unit/... for examples) or one of the core developers will need to add it as time permits. Thanks!

@ghost ghost assigned danielgtaylor Jan 20, 2014

I wondered about that, but couldn't see a unit test for get_endpoint_attributes. Unfortunately, all the SNS unit tests appear to be for creation of content, not getting content.

Sorry, but I'm unlikely to get through the learning curve for this small fix at this stage. If someone else wants to pick it up, please do so...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment