Route53 Record.set_alias was broken by the addition of target health evaluation #2126

Merged
merged 2 commits into from Feb 27, 2014

2 participants

@jimbrowne

Fix breakage and add tests for the new usage and original usage. Include health evaluation status in to_print.

I honestly am not sure if the default should be True or False; all of my pre-existing Route53 records report True when using the newer API, so I chose True as the default (though the docs note this may break for CloudFront targets.)

jimbrowne added some commits Feb 27, 2014
@jimbrowne jimbrowne Route53 Record.set_alias was broken by the addition of target
health evaluation.  Fix this and add tests for the new usage
and original usage.  Include health evaluation status in to_print.
34fd139
@jimbrowne jimbrowne Fix route53 alias to_print and change default health eval to False e8e1de1
@jimbrowne

I had an incorrect addition to the to_print as alias_evaluate_target_health is handled as a string rather than converted to a proper boolean. Based on that fix I've changed the default to False as that matches all of my existing Route53 records created with the old Route53 API.

@danielgtaylor danielgtaylor self-assigned this Feb 27, 2014
@danielgtaylor
the boto project member

Thanks for the fix and tests 👍

@danielgtaylor danielgtaylor merged commit 141077f into boto:develop Feb 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment