S3 meta data handle plus sign #2145

Closed
wants to merge 2 commits into
from

2 participants

@danielbeardsley

Previously, there was no way to reliably store and then retrieve
metadata values that contained plus signs. quote_plus left existing
pluses as they were while encoding spaces as "+". This would turn a
value like "x+ +x" into "x+++x" which upon retrieval from S3 using boto
would be decoded into "x x".

This change allows storage of plus characters "+" in s3 key metadata
values.

danielbeardsley added some commits Mar 5, 2014
@danielbeardsley danielbeardsley S3 Metadata: add failing test case for plus signs
Without adding your own encoding layer ontop of boto's, there is no way
to reliably store and then retrieve meta-data values that contain plus
signs. quote_plus leaves existing pluses as they are while encoding
spaces as "+". This turns a value like "x+ +x" into "x+++x" which upon
retrieval from S3 using boto is decoded into "x   x".

A further commit will fix the bug.
c31948b
@danielbeardsley danielbeardsley S3 Metadata: allow storage of plus signs (+)
Previously, there was no way to reliably store and then retrieve
meta-data values that contained plus signs. quote_plus left existing
pluses as they were while encoding spaces as "+". This would turn a
value like "x+ +x" into "x+++x" which upon retrieval from S3 using boto
would be decoded into "x   x".

This change allows storage of plus characters "+" in s3 key metadata
values.
0cd4579
@toastdriven toastdriven self-assigned this Mar 13, 2014
@toastdriven

Thanks!

@toastdriven toastdriven removed their assignment Mar 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment