New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RegionInfo by default with heuristics #3737

Merged
merged 1 commit into from Jun 14, 2017

Conversation

Projects
None yet
4 participants
@JordonPhillips
Copy link
Contributor

JordonPhillips commented Jun 2, 2017

The generic connect wasn't using the RegionInfo class by default. This had been masked by two things:

  1. get_regions properly uses this as the default. Most tests only go through get_regions so most tests wouldn't encounter this at all.
  2. The tests explicitly for the region heuristics all provide a custom region class.

This fixes the issue and adds tests that would fail if the default were not correctly set.

Anybody on an impacted version can unblock themselves by passing region_cls=RegionInfo into their connect call.

@xerebz

This comment has been minimized.

Copy link

xerebz commented Jun 3, 2017

LGTM

@kyleknap
Copy link
Member

kyleknap left a comment

Looks good. 🚢

@JordonPhillips JordonPhillips merged commit 0a9b114 into boto:develop Jun 14, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment