New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update layer1.py #3765

Merged
merged 3 commits into from Oct 24, 2017

Conversation

Projects
None yet
2 participants
@knil-sama
Copy link
Contributor

knil-sama commented Oct 4, 2017

Add more information on rebuild_environment

Get this error on aws
@mfschwartz
An error occurred (InvalidParameterValue) when calling the RebuildEnvironment operation: No Environment found for EnvironmentName = 'XXXXXXX'.

Update layer1.py
Add more information on rebuild_environment
@@ -772,6 +772,8 @@ def rebuild_environment(self, environment_id=None, environment_name=None):
Condition: You must specify either this or an EnvironmentId, or
both. If you do not specify either, AWS Elastic Beanstalk returns
MissingRequiredParameter error.
If the environment hadn't be created or is terminated returns

This comment has been minimized.

@mfschwartz

mfschwartz Oct 24, 2017

Member

Can you please clarify why this might happen? What could cause environment creation to fail?

This comment has been minimized.

@knil-sama

knil-sama Oct 24, 2017

Contributor

I just want to clarify that the environment must already exist and be in a not terminated state.
My use case is that I wanted to use it to rebuild in the morning environment I terminated in the night, that raise this InvalidParameterValue that wasn't documented.

This comment has been minimized.

@mfschwartz

mfschwartz Oct 24, 2017

Member

(FYI I haven't worked with this part of the code, which is why I'm asking these questions.)

The thing that confused me is that the function is called "rebuild_environment", so at first I thought your comment was saying the function wasn't able to rebuild the environment, rather than there was a problem with the environment you passed in.

How about this:

  • Move this to a raises: clause below
  • In that clause say "InvalidParameterValue if environment_name doesn't refer to a currently active environment."

knil-sama added some commits Oct 24, 2017

Update layer1.py
Change according to request in review

@mfschwartz mfschwartz merged commit 5334015 into boto:develop Oct 24, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@knil-sama

This comment has been minimized.

Copy link
Contributor

knil-sama commented Oct 24, 2017

@mfschwartz Yes that would be better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment