Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to support uploads to KMS-encrypted buckets. #3800

Merged
merged 1 commit into from Mar 12, 2018
Merged

Conversation

@houglum
Copy link
Contributor

@houglum houglum commented Mar 12, 2018

This fixes uploads to buckets with default KMS keys failing, e.g.:

$ echo "<some text here>" | ./gsutil cp - gs://<MyKmsEncryptedBucketHere>/object1
GSDataError: BotoClientError: ETag from S3 did not match computed MD5. "-CMPujcLB4NkCEAE=" vs. 25a14f7d6fdde4161404a71d7817a0b4

@houglum
Copy link
Contributor Author

@houglum houglum commented Mar 12, 2018

@mfschwartz, please merge when you get the chance. As with the previous pull request, the failing TravisCI tests are due to the cryptography package (in Py 2.6 and 3.3) that Boto depends on. I've run all the integration tests and manually tested with gsutil as well. Thanks!

@mfschwartz mfschwartz merged commit 0a1d904 into boto:develop Mar 12, 2018
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@CRIPTOPIK

This comment has been minimized.

Copy link

@CRIPTOPIK CRIPTOPIK commented on boto/s3/key.py in 7509420 Mar 14, 2018

self ._storage_class = resp.getheader (

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants