Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added missing (boolean) is_latest attribute to Key object. #510

Merged
merged 1 commit into from Jan 25, 2012

Conversation

Projects
None yet
2 participants
Contributor

tpodowd commented Jan 23, 2012

  • added missing attribute is_latest to key object
    • default value is False.
  • is_latest is set when reading XML response of get versions
    in the same way the DeleteMarker is_latest gets set.
  • Added unit tests to test_versioning.py
Thomas O'Dowd Added missing (boolean) is_latest attribute to Key object.
- added missing attribute is_latest to key object
  * default value is False.
- is_latest is set when reading XML response of get versions
  in the same way the DeleteMarker is_latest gets set.
- Added unit tests to test_versioning.py
cab1346
Contributor

tpodowd commented Jan 23, 2012

Also note: I'd like to pull mfa stuff out of the test_versioning.py at some stage into a perhaps test_mfa.py as I think its useful to be able to run the test_versioning stuff separately. I don't have an mfa key myself so I have to disable the whole test right now when I want to test stuff. then just have test suites for "s3" and "s3nomfa" instead of "s3nover". Can do that on another branch though once this is pulled in if people like the idea.

Owner

garnaat commented Jan 25, 2012

Yes, I agree with you on splitting out versioning and MFA.

@garnaat garnaat closed this Jan 25, 2012

@garnaat garnaat reopened this Jan 25, 2012

Owner

garnaat commented Jan 25, 2012

Sorry, just hit the "close & comment" button rather than "comment". I'm about to merge this so it will then be really closed.

@garnaat garnaat added a commit that referenced this pull request Jan 25, 2012

@garnaat garnaat Merge pull request #510 from tpodowd/fix_latest_key
Added missing (boolean) is_latest attribute to Key object.
fd334d9

@garnaat garnaat merged commit fd334d9 into boto:master Jan 25, 2012

@msabramo msabramo pushed a commit to msabramo/boto that referenced this pull request Nov 28, 2012

@garnaat garnaat Merge pull request #510 from tpodowd/fix_latest_key
Added missing (boolean) is_latest attribute to Key object.
83a82ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment