Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Please review change. Code correctly creates DHCP Options Set, unsure if section for adding parameters follows proper boto coding standards. #589

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
1 participant

...ApiReference-query-CreateDhcpOptions.html for changes.

CreateDhcpOption changed to CreateDhcpOptions and params generation changed to provide proper Key/Value request parameters.

Example usage:

vpcconn = VPCConnection(region=useast1)
optionz = {'domain-name': "cloud.infor.com",
'domain-name-servers' : ['172.18.9.10', '172.18.9.20'],
'ntp-servers' : ['172.18.9.10', '172.18.9.20'],
'netbios-name-servers' : ['172.18.9.10', '172.18.9.20'],
'netbios-node-type' : "2"}
myoptions=vpcconn.create_dhcp_options(optionz)

Mike Savage Referenced http://docs.amazonwebservices.com/AWSEC2/latest/APIReferen…
…ce/ApiReference-query-CreateDhcpOptions.html for changes.

CreateDhcpOption changed to CreateDhcpOptions and params generation changed to provide proper Key/Value request paramters.
90a25c2

@dyzsasd dyzsasd pushed a commit to dailymotion/boto that referenced this pull request May 9, 2017

@kyleknap kyleknap Merge pull request #589 from frewsxcv/patch-1
Fix typo: 'paramters' → 'parameters'.
3caff3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment