Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed #581 - Install requires filechunkIO for s3multiput #611

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

fabiant7t commented Mar 2, 2012

Added filechunkIO as a requirement to setup.py. It is used in bin/s3multiput.

Owner

kopertop commented Mar 2, 2012

If filechunkIO is only required for a script, or even just one small part of boto, and not for core functionality, it's probably beat to not require it just to install boto itself.

Contributor

fabiant7t commented Mar 3, 2012

@kopertop Since the script that requires filechunkIO, s3multiput, is part of the repository, it will get used and should not raise an ImportError. Especially because the audience of a command line utility is not necessarily experienced in Python.

As the author of filechunkIO, I can tell you that is is well tested, has no further dependencies and is working in production (we use it on a daily basis to transfer massive amounts of videos and Duplicity uses it).

blowery commented Oct 26, 2012

+1 on this. Bit me in the ass today, until I realized I needed to install filechunkIO to make the script work. Yay wasted time.

jbyers commented Aug 1, 2013

I was surprised by the missing dependency in our version of boto as well. It turns out as part of the merger of s3multiput and s3put there's now a friendly warning about filechunkio being required for multiput:

#1078 [github.com/boto/boto/pull/1078]
https://github.com/glance-/boto/commit/e377805cb2f9fb0e7244307cc7167b0c2f38fb93 [github.com/glance-/boto/commit/e377805cb2f9fb0e7244307cc7167b0c2f38fb93]

I wouldn't mind filechunkio being included in setup.py, but this seems like a good compromise for those who need multiput support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment