Add __repr__ to GlacierResponse #982

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@schworer
Contributor

schworer commented Sep 12, 2012

Since GlacierResponse inherits from dict, it was not obvious at first that the object has other methods and attributes, which makes discovering how to read data back from Glacier non-obvious.
Hopefully this helps users with discoverability.

Add __repr__ to GlacierResponse
Since GlacierResponse inherits from dict, it was not obvious at first that the object has other methods and attributes, which makes discovering how to read data back from Glacier non-obvious.
Hopefully this helps users with discoverability.
@garnaat

This comment has been minimized.

Show comment Hide comment
@garnaat

garnaat Nov 14, 2012

Owner

I think the best approach here would be to change the GlacierResponse to be a custom object that contains a dict and also the read method. That way, the dict is still a dict but it becomes more clear that the object returned has other capabilities.

Owner

garnaat commented Nov 14, 2012

I think the best approach here would be to change the GlacierResponse to be a custom object that contains a dict and also the read method. That way, the dict is still a dict but it becomes more clear that the object returned has other capabilities.

@schworer

This comment has been minimized.

Show comment Hide comment
@schworer

schworer Nov 14, 2012

Contributor

Agreed -- should GlacierResponse simply inherit from object, or is there another base class in the boto libs that would be more appropriate?

Contributor

schworer commented Nov 14, 2012

Agreed -- should GlacierResponse simply inherit from object, or is there another base class in the boto libs that would be more appropriate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment