logger utils #991

Closed
wants to merge 7 commits into
from

Projects

None yet

4 participants

@yadutaf
yadutaf commented Sep 17, 2012

As per IRC, here are the refactored logger utils. There is also a suggested implementation to hook the perf logger directly into parent make_request but, honestly, I'm not a big fan of this solution. Let me know if you want this commit revert.

@yadutaf
yadutaf commented Oct 5, 2012

Any update on this ?

@kopertop
Member
kopertop commented Oct 9, 2012

Profile isn't something that should generally be turned on in production, and I'm curios to know what the performance hit is for simply calculating the elapsed time. It may be irrelevant, but it certainly isn't a zero-cost initiative even when performance checking is turned off.

I'd feel much better if there was a simple way to turn off all performance calculations entirely.

Jean-Tiare LE BIGOT add 'boto.enable_performance_logger' flag to globally enable/disable …
…the performance logger. Turn it off by default
05cd969
@yadutaf
yadutaf commented Oct 17, 2012

This is a good point. I added a flag to turn the logger on. It is off by default. I don't know if it saves much though.

Jean-Tiare L... added some commits Oct 23, 2012
Jean-Tiare LE BIGOT boto.perf formating 3373eae
Jean-Tiare LE BIGOT boto.perf formating (bis) 4f21e71
@garnaat
Member
garnaat commented Nov 14, 2012

We decided to change the logging level to debug on the performance logging in dynamodb/layer1.py. This should eliminate logging for all normal conditions.

@jamesls jamesls added a commit that closed this pull request Nov 14, 2012
@jamesls jamesls Switch perflog to log at debug level for dynamodb
Fixes #991.
311710a
@jamesls jamesls closed this in 311710a Nov 14, 2012
@msabramo msabramo pushed a commit to msabramo/boto that referenced this pull request Nov 28, 2012
@jamesls jamesls Switch perflog to log at debug level for dynamodb
Fixes #991.
1250f5d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment