Generally retry provisioned throughput exceptions #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we only retried the ProvisionedThroughputExceededException for DynamoDB. Now we retry it for all services, which was now needed specifcally for Textract and Rekognition. Furthermore, the other SDK's retry ProvisionedThroughputExceededException across all services already so we would be more consistent with the other SDK's as well.
kyleknap
requested review from
dstufft,
JordonPhillips,
joguSD,
jamesls and
stealthycoin
dstufft
approved these changes
Jun 18, 2019
joguSD
approved these changes
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we only retried the
ProvisionedThroughputExceededExceptionfor DynamoDB. Now we will be retrying it for all services. The new services that this will encompass include TextTract, Rekognition, and Kinesis. In general, these services would throw this exception and the only way to get around it would be to retry or get your limits increased. So it made sense to retry it similar to what we do for DynamoDB. Furthermore, the other SDK's retry ProvisionedThroughputExceededException across all services already so we would be more consistent with the other SDK's as well.