Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imds metadata #1895

Merged
merged 3 commits into from Nov 20, 2019
Merged

Imds metadata #1895

merged 3 commits into from Nov 20, 2019

Conversation

@stealthycoin
Copy link
Contributor

stealthycoin commented Nov 20, 2019

No description provided.

@stealthycoin stealthycoin requested review from jamesls, joguSD and kyleknap Nov 20, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 20, 2019

Codecov Report

Merging #1895 into develop will increase coverage by 0.01%.
The diff coverage is 97.72%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1895      +/-   ##
===========================================
+ Coverage    92.57%   92.58%   +0.01%     
===========================================
  Files           53       53              
  Lines        10001    10035      +34     
===========================================
+ Hits          9258     9291      +33     
- Misses         743      744       +1
Impacted Files Coverage Δ
botocore/utils.py 97.93% <97.72%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae41ef1...66ee37d. Read the comment docs.

return None
elif response.status_code in (400,):
raise BadIMDSRequestError(request)
except ReadTimeoutError:

This comment has been minimized.

Copy link
@joguSD

joguSD Nov 20, 2019

Contributor

Are we sure that this will always get raised as a read timeout? When I was working on the urllib3 changes I remember some scenarios where it was ambiguous exactly what timeout error would get raised.

This comment has been minimized.

Copy link
@stealthycoin

stealthycoin Nov 20, 2019

Author Contributor

In the repro case it appears to only be that error.

@joguSD
joguSD approved these changes Nov 20, 2019
@joguSD joguSD merged commit 3f38f12 into boto:develop Nov 20, 2019
3 checks passed
3 checks passed
codecov/patch 97.72% of diff hit (target 92.57%)
Details
codecov/project 92.58% (+0.01%) compared to ae41ef1
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.