Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter warnings more narrowly in test_BOTO_DISABLE_COMMONNAME #2753

Merged
merged 1 commit into from Sep 2, 2022

Conversation

jonemo
Copy link
Contributor

@jonemo jonemo commented Sep 2, 2022

Two changes for the test tests.unit.test_client:TestClientErrors.test_BOTO_DISABLE_COMMONNAME:

  1. Instead of the deprecated pytest.warns(None), use warnings.catch_warnings(record=True) as suggested in the pytest docs
  2. More narrowly look for the specific type of warning emitted when deprecated endpoints are used

This may address, or at least provide more details for, #2752.

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2022

Codecov Report

Merging #2753 (1c5bbb6) into develop (db286e3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2753   +/-   ##
========================================
  Coverage    95.13%   95.13%           
========================================
  Files           61       61           
  Lines        12530    12530           
========================================
  Hits         11920    11920           
  Misses         610      610           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@dlm6693 dlm6693 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @jonemo!

@nateprewitt nateprewitt merged commit 13e6483 into boto:develop Sep 2, 2022
@jonemo jonemo deleted the test-botocore-disable-commonname branch September 2, 2022 16:20
aws-sdk-python-automation added a commit that referenced this pull request Sep 2, 2022
* release-1.27.66:
  Bumping version to 1.27.66
  Update to latest endpoints
  Update to latest models
  filter warnings more narrowly in test_BOTO_DISABLE_COMMONNAME (#2753)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants