Add a settimeout() method to FakeSocket - #2810
Merged
Merged
Conversation
nateprewitt
approved these changes
Nov 10, 2022
nateprewitt
left a comment
nateprewitt
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, thanks @sethmlarson!
Codecov ReportBase: 93.45% // Head: 93.45% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #2810 +/- ##
========================================
Coverage 93.45% 93.45%
========================================
Files 63 63
Lines 13298 13298
========================================
Hits 12427 12427
Misses 871 871 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
aws-sdk-python-automation
added a commit
that referenced
this pull request
Nov 11, 2022
* release-1.29.8: Bumping version to 1.29.8 Update to latest partitions and endpoints Update to latest models Add a settimeout() method to FakeSocket (#2810)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a part of urllib3 v2.0 we changed how
HTTPConnectionPoolsinteract with innerHTTPConnectionobjects, mostly to remove manipulation of inner state like the socket. Instead now theHTTPConnectioncallssettimeout()on it's own socket.We also run botocore in our integration tests, and this change caused a failure where
FakeSocketdidn't have thesettimeoutmethod. This PR is upstreaming the patch we have committed to our repository.