Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add override for NotificationARNs #283

Merged
merged 2 commits into from May 14, 2014

Conversation

danielgtaylor
Copy link
Member

This fixes a bug where the CLI argument was set to --notification-ar-ns (docs). The original parameter is NotificationARNs, as can be seen here:

http://docs.aws.amazon.com/AWSCloudFormation/latest/APIReference/API_UpdateStack.html

Confirmed to work in the CLI now:

SYNOPSIS
            update-stack
          --stack-name <value>
          [--template-body <value>]
          [--template-url <value>]
          [--use-previous-template | --no-use-previous-template]
          [--stack-policy-during-update-body <value>]
          [--stack-policy-during-update-url <value>]
          [--parameters <value>]
          [--capabilities <value>]
          [--stack-policy-body <value>]
          [--stack-policy-url <value>]
          [--notification-arns <value>]

@jamesls please review.

@@ -44,6 +44,7 @@ def emit(self, record):
('DescribeStorediSCSIVolumes', '-'): 'describe-stored-iscsi-volumes',
('CreateStorediSCSIVolume', '_'): 'create_stored_iscsi_volume',
('CreateStorediSCSIVolume', '-'): 'create-stored-iscsi-volume',
('NotificationARNs', '-'): 'notification-arns',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need one for the underscore version as well, though I know it'd be nice if we didn't have to duplicate entries like this.

@jamesls
Copy link
Member

jamesls commented May 14, 2014

:shipit:

danielgtaylor added a commit that referenced this pull request May 14, 2014
Add override for NotificationARNs. Fixes #283.
@danielgtaylor danielgtaylor merged commit 578465e into boto:develop May 14, 2014
@danielgtaylor danielgtaylor deleted the notification-arns branch May 14, 2014 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants