Fix links and code edge cases in docs generation #2896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## develop #2896 +/- ##
========================================
Coverage 93.58% 93.59%
========================================
Files 63 63
Lines 13516 13517 +1
========================================
+ Hits 12649 12651 +2
+ Misses 867 866 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
aws-sdk-python-automation
added a commit
that referenced
this pull request
Mar 28, 2023
* release-1.29.101: Bumping version to 1.29.101 Update to latest partitions and endpoints Update to latest models Fix links and code edge cases in docs generation (#2896)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two classes of errors that were introduced in #2855:
“) instead of plain".As part of investigating this, I found that the special treatment for trailing whitespace in data nodes (where one whitespace is always left behind) is another special case whitespace treatment longer needed and removed it.
Examples
Before
After
Before
After
Before
After
Testing
Spot checked HTML of ~200 pages with diffs from the changes in this PR. All of them are either fixes of the issues described above, or further removals of unnecessary whitespace.