Skip to content

Add support for aws_chunked with s3v4.#996

Closed
timuralp wants to merge 1 commit intoboto:developfrom
timuralp:feature/aws-chunked
Closed

Add support for aws_chunked with s3v4.#996
timuralp wants to merge 1 commit intoboto:developfrom
timuralp:feature/aws-chunked

Conversation

@timuralp
Copy link
Contributor

@timuralp timuralp commented Aug 3, 2016

When uploading to S3 from a stream, it would be useful to opt into S3
aws_chunked uploads with v4 signatures. The mechanism is documented
here:
http://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-streaming.html

The feature is implemented through a new auth class --
S3SigV4ChunkedAuth. The class wraps the body of the request with a
ChunkedUploadWrapper instance. It takes care of producing fixed size
upload chunks and computing the required signatures for each one.

To opt into this scheme, the caller is required to set the aws_chunked
option for client configuration and it will only be used with the
PutObject operations.

Fixes #995

@timuralp
Copy link
Contributor Author

timuralp commented Aug 3, 2016

I wasn't sure if this is the right approach to this problem and the PR doesn't have any unit tests at the moment. If there is agreement that this make sense or guidance on how to rework it, I'm happy to work further on the PR and add the tests.

@codecov-io
Copy link

codecov-io commented Aug 3, 2016

Codecov Report

Merging #996 into develop will decrease coverage by 1.35%.
The diff coverage is 89.14%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #996      +/-   ##
===========================================
- Coverage    98.03%   96.68%   -1.36%     
===========================================
  Files           45       44       -1     
  Lines         7345     7264      -81     
===========================================
- Hits          7201     7023     -178     
- Misses         144      241      +97
Impacted Files Coverage Δ
botocore/signers.py 97.25% <80%> (-1.19%) ⬇️
botocore/auth.py 96.29% <89.51%> (-2.01%) ⬇️
botocore/configloader.py 75.94% <0%> (-24.06%) ⬇️
botocore/compat.py 68.14% <0%> (-23.71%) ⬇️
botocore/translate.py 92.68% <0%> (-7.32%) ⬇️
botocore/handlers.py 94.13% <0%> (-2.19%) ⬇️
botocore/docs/sharedexample.py 97.16% <0%> (-1.42%) ⬇️
botocore/docs/bcdoc/style.py 94.05% <0%> (-1.17%) ⬇️
botocore/paginate.py 96.59% <0%> (-0.61%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81f8c4c...d27e1e6. Read the comment docs.

@jamesls
Copy link
Member

jamesls commented Aug 3, 2016

Linking issues, boto3 tracking issue: boto/boto3#751

Pending discussion over on the issue.

@timuralp timuralp force-pushed the feature/aws-chunked branch from 8cf59e6 to b1e1297 Compare August 11, 2016 23:57
When uploading to S3 from a stream, it would be useful to opt into S3
aws_chunked uploads with v4 signatures. The mechanism is documented
here:
http://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-streaming.html

The feature is implemented through a new auth class --
S3SigV4ChunkedAuth. The class wraps the body of the request with a
ChunkedUploadWrapper instance. It takes care of producing fixed size
upload chunks and computing the required signatures for each one.

To opt into this scheme, the caller is required to set the aws_chunked
option for client configuration and it will only be used with the
PutObject operations.

Fixes boto#995
@timuralp timuralp force-pushed the feature/aws-chunked branch from b1e1297 to d27e1e6 Compare July 22, 2017 00:44
@stealthycoin stealthycoin added feature-request This issue requests a feature. large labels Sep 13, 2017
@kyleknap kyleknap removed the large label Feb 27, 2020
@github-actions
Copy link

Greetings! It looks like this issue hasn’t been active in longer than one year. We encourage you to check if this is still an issue in the latest release. Because it has been longer than one year since the last update on this, and in the absence of more information, we will be closing this issue soon. If you find that this is still a problem, please feel free to provide a comment to prevent automatic closure, or if the issue is already closed, please feel free to reopen it.

@timuralp
Copy link
Contributor Author

timuralp commented Mar 3, 2021

I don't know if there is anything I could've done to draw more attention to this or generate discussion. In light of lack of desire to discuss this feature, it probably makes sense to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for streaming (transfer-encoding: chunked) v4 uploads

5 participants