fix(nlu): warn of duplication on synonym removal (#4387)

botpress · Jan 20, 2021 · 09da1ec · 09da1ec
1 parent a4677ec
commit 09da1ec
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/modules/nlu/src/views/full/entities/ListEntity.tsx b/modules/nlu/src/views/full/entities/ListEntity.tsx
@@ -90,9 +90,16 @@ export const ListEntityEditor: React.FC<Props> = props => {
   }
 
   const editOccurrence = (idx: number, occurrence: NLU.EntityDefOccurrence) => {
-    const newSynonym = _.last(occurrence.synonyms)
-    if (!isUnique(newSynonym)) {
-      return toastFailure('Synonyms duplication is not allowed')
+    const synonymAdded = () => {
+      const oldOccurence = state.occurrences[idx]
+      return oldOccurence.synonyms.length < occurrence.synonyms.length
+    }
+
+    if (synonymAdded()) {
+      const newSynonym = _.last(occurrence.synonyms)
+      if (!isUnique(newSynonym)) {
+        return toastFailure('Synonyms duplication is not allowed')
+      }
     }
 
     const occurrences = [...state.occurrences.slice(0, idx), occurrence, ...state.occurrences.slice(idx + 1)]