Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migrations): execute migrations after modules are loaded #2246

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@rndlaine
Copy link
Member

commented Aug 14, 2019

There was an issue with modules migrations where the migration was applied before the table is created. I just changed the order of execution to load modules before migrations are executed.

@rndlaine rndlaine changed the base branch from master to patch/12-1-1 Aug 14, 2019

@rndlaine rndlaine changed the title fix(migrations): execute migrations after modules tables are created fix(migrations): execute migrations after modules are loaded Aug 14, 2019

@allardy

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

I think I remember why I left it before modules were loaded... It was so we could apply modification to config, content, etc before modules use them. But it was more hypothetical then, and restarting BP would fix any issue.

So, that's a good fix

@EFF
EFF approved these changes Aug 15, 2019

@slvnperron slvnperron merged commit aa3ca17 into patch/12-1-1 Aug 16, 2019

2 checks passed

AWS CodeBuild us-east-1 (botpress-ce-tests) Build succeeded for project botpress-ce-tests
Details
license/cla All CLA requirements met.

@slvnperron slvnperron deleted the rl_fix-module-migrations branch Aug 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.