From 1527d39b7d1ccad565a080cefae20a75c614000c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Samuel=20Mass=C3=A9?=
 <59894025+samuelmasse@users.noreply.github.com>
Date: Fri, 11 Feb 2022 15:32:55 -0500
Subject: [PATCH] fix(api): fix broken providers creation (#354)

---
 packages/server/src/clients/api.ts | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/packages/server/src/clients/api.ts b/packages/server/src/clients/api.ts
index 3ea8819d7..017dc3caf 100644
--- a/packages/server/src/clients/api.ts
+++ b/packages/server/src/clients/api.ts
@@ -33,13 +33,17 @@ export class ClientApi {
   }
 
   async create(req: Request, res: Response) {
-    const clientId: uuid = req.body.id
+    let clientId: uuid | undefined = req.body.id
 
     if (clientId && (await this.clients.fetchById(clientId))) {
       return res.status(403).send(`client with id "${clientId}" already exists`)
     }
 
-    const provider = await this.providers.create(clientId || uuidv4(), false)
+    if (!clientId) {
+      clientId = uuidv4()
+    }
+
+    const provider = await this.providers.create(clientId, false)
     const client = await this.clients.create(provider.id, clientId)
 
     const rawToken = await this.clientTokens.generateToken()