pubsys: only create tokio runtime when needed #1034
Merged
+15
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tough-ssm creates its own tokio runtime for making SSM calls, so we can't use it inside our own tokio runtime. This change removes the general `[tokio::main]` annotation that creates a runtime for the entire app, and instead only creates a runtime inside the `ami` subcommand that needs one. We can switch back to the annotation when tough-ssm moves to an async interface.
iliana
approved these changes
Aug 13, 2020
etungsten
approved these changes
Aug 13, 2020
bcressey
approved these changes
Aug 13, 2020
etungsten
added a commit
to etungsten/bottlerocket
that referenced
this pull request
Aug 13, 2020
etungsten
added a commit
that referenced
this pull request
Aug 13, 2020
Add PR #1034 to the 0.5.0 changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tough-ssm creates its own tokio runtime for making SSM calls, so we can't use
it inside our own tokio runtime. This change removes the general
[tokio::main]annotation that creates a runtime for the entire app, andinstead only creates a runtime inside the
amisubcommand that needs one. Wecan switch back to the annotation when tough-ssm moves to an async interface.
Testing done:
Created a repo using an SSM key, and created an AMI, and confirmed that both look OK.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.