Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix impartial negative number parsing #11

Merged
merged 2 commits into from
Feb 9, 2019
Merged

Fix impartial negative number parsing #11

merged 2 commits into from
Feb 9, 2019

Conversation

boudra
Copy link
Owner

@boudra boudra commented Feb 9, 2019

The stream parser fails when parsing a document chunked like this:

{"number": - 2}

Now it handles this case correctly.

@boudra boudra added the bug Something isn't working label Feb 9, 2019
@boudra boudra changed the title Fix impartial negative number Fix impartial negative number parsing Feb 9, 2019
@boudra boudra merged commit 824ab6c into master Feb 9, 2019
@boudra boudra deleted the fix/impartial-negative-number branch February 9, 2019 22:55
@coveralls
Copy link

Pull Request Test Coverage Report for Build 71

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 86.452%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/jaxon/parse_error.ex 0 1 0.0%
Totals Coverage Status
Change from base Build 68: -0.6%
Covered Lines: 134
Relevant Lines: 155
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 71

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 86.452%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/jaxon/parse_error.ex 0 1 0.0%
Totals Coverage Status
Change from base Build 68: -0.6%
Covered Lines: 134
Relevant Lines: 155
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boudra @coveralls