Change the order of delete cascade for `spiral' #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A crash of `folsom_metrics_histogram_ets` leaves spirals broken. The spiral ets table goes away, so it can not be updated, nor can it be deleted and re-created due to the delete order of metric table, spiral table, folsom table. Have changed the order to be more like that of `histogram` so deletes will succeed in the event of a missing `spiral` ets table.
joewilliams
added a commit
that referenced
this pull request
Mar 18, 2013
Change the order of delete cascade for `spiral'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A crash of
folsom_metrics_histogram_etsleaves spirals broken.The spiral ets table goes away, so it can not be updated, nor
can it be deleted and re-created due to the delete order of
metric table, spiral table, folsom table. Have changed the order
to be more like that of
histogramso deletes will succeed inthe event of a missing
spiralets table.(Addresses #55)