Skip to content
Permalink
Browse files

ENGR00236169 MX6 USB :kfree udc_controller when remove udc driver

Kree and reset udc_controller should be done when remove udc driver to avoid
kernel dump during modprobe gadget driver after modprobe and rmmod udc driver.

Signed-off-by: make shi <b15407@freescale.com>
  • Loading branch information...
make shi authored and LiuHui-Jason committed Dec 10, 2012
1 parent 4f40f43 commit c27cb3851bb6f822f8a92e4a1e10fba19284bdd4
Showing with 3 additions and 6 deletions.
  1. +3 −6 drivers/usb/gadget/arcotg_udc.c
@@ -2911,6 +2911,7 @@ static void fsl_udc_release(struct device *dev)
dma_free_coherent(dev, udc_controller->ep_qh_size,
udc_controller->ep_qh, udc_controller->ep_qh_dma);
kfree(udc_controller);
udc_controller = NULL;
}

/******************************************************************
@@ -3255,8 +3256,7 @@ static int fsl_udc_remove(struct platform_device *pdev)
return -ENODEV;
udc_controller->done = &done;
/* open USB PHY clock */
if (udc_controller->stopped)
dr_clk_gate(true);
dr_clk_gate(true);

/* disable wake up and otgsc interrupt for safely remove udc driver*/
temp = fsl_readl(&dr_regs->otgsc);
@@ -3296,7 +3296,7 @@ static int fsl_udc_remove(struct platform_device *pdev)
release_mem_region(res->start, resource_size(res));
}
#endif

dr_clk_gate(false);
device_unregister(&udc_controller->gadget.dev);
/* free udc --wait for the release() finished */
wait_for_completion(&done);
@@ -3307,9 +3307,6 @@ static int fsl_udc_remove(struct platform_device *pdev)
if (pdata->exit)
pdata->exit(pdata->pdev);

if (udc_controller->stopped)
dr_clk_gate(false);

return 0;
}

0 comments on commit c27cb38

Please sign in to comment.
You can’t perform that action at this time.