Skip to content

Commit 8104859

Browse files
authored
chore: fix concurrency groups (#1902)
<!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Fix concurrency group naming in GitHub workflows to prevent deadlocks by adding specific suffixes. > > - **Concurrency Group Fixes**: > - In `build-vscode-release.reusable.yaml`, added suffix `-build-vscode` to concurrency group to prevent deadlocks. > - In `integ-tests.yml`, added suffix `-integ-tests` to concurrency group to prevent deadlocks. > - In `release.yml`, added comment explaining the need for a statically-defined suffix in reusable workflows to prevent deadlocks. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=BoundaryML%2Fbaml&utm_source=github&utm_medium=referral)<sup> for 66b0e3b. You can [customize](https://app.ellipsis.dev/BoundaryML/settings/summaries) this summary. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
1 parent 1f479c9 commit 8104859

3 files changed

Lines changed: 9 additions & 1 deletion

File tree

.github/workflows/build-vscode-release.reusable.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
name: BAML Release - Build VSCode Extension (Matrix Packaging)
22

3+
concurrency:
4+
# suffix is important to prevent a concurrency deadlock with the calling workflow
5+
group: ${{ github.workflow }}-${{ github.ref }}-build-vscode
6+
cancel-in-progress: true
7+
38
on:
49
workflow_call:
510
inputs:

.github/workflows/integ-tests.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ on:
88
branches: [ sam/integ-tests-ci ]
99

1010
concurrency:
11-
group: ${{ github.workflow }}-${{ github.ref }}
11+
# suffix is important to prevent a concurrency deadlock with the calling workflow
12+
group: ${{ github.workflow }}-${{ github.ref }}-integ-tests
1213
cancel-in-progress: true
1314

1415
permissions:

.github/workflows/release.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ on:
1717
- "test-release/*.*"
1818
- "*.*"
1919
concurrency:
20+
# No suffix specified - in reusable workflows we need a statically-defined suffix
21+
# to prevent workflow_call workflows from triggering a concurrency deadlock
2022
group: ${{ github.workflow }}-${{ github.ref }}
2123
cancel-in-progress: true
2224

0 commit comments

Comments
 (0)