Fix issues with some tests, remove old LSP code (#2031)

<!-- ELLIPSIS_HIDDEN -->



> [!IMPORTANT]
> Update build process and test configurations, including a new release
build script and minor test adjustments.
> 
>   - **Build Process**:
> - Update build command in
`.github/workflows/build-vscode-release.reusable.yaml` from `pnpm run
build` to `pnpm run build:release`.
> - Add `server:build:release` script in `package.json` for VSCode
extension.
>   - **Tests**:
> - Change model name in `modular.test.ts` from 'gemini-1.5-pro-001' to
'gemini-1.5-pro'.
>   - **Code Cleanup**:
>     - Remove unnecessary whitespace in `types.go`.
>     - Remove `baml-client#build` dependency in `turbo.json`.
> 
> <sup>This description was created by </sup>[<img alt="Ellipsis"
src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=BoundaryML%2Fbaml&utm_source=github&utm_medium=referral)<sup>
for 1f69e1f. You can
[customize](https://app.ellipsis.dev/BoundaryML/settings/summaries) this
summary. It will automatically update as commits are pushed.</sup>

<!-- ELLIPSIS_HIDDEN -->

Author: aaronvg

.github/workflows/build-vscode-release.reusable.yaml

@@ -9,11 +9,11 @@ on:
   workflow_call:
     inputs:
       is_release_build:
-        description: 'Whether this is a release build (affects --pre-release flag)'
+        description: "Whether this is a release build (affects --pre-release flag)"
         type: boolean
         default: true
       version:
-        description: 'Version string to use for the build'
+        description: "Version string to use for the build"
         type: string
         required: true
 
@@ -66,14 +66,14 @@ jobs:
         uses: actions/download-artifact@v4
         with:
           name: baml-cli-${{ matrix.rust-target }}
-          path: cli-artifact-${{ matrix.code-target }} 
+          path: cli-artifact-${{ matrix.code-target }}
           # Unique path per job
         # Add error handling if the specific artifact isn't found
 
       - name: List downloaded artifact content
         run: |
-           echo "Contents of cli-artifact-${{ matrix.code-target }} directory:"
-           ls -R cli-artifact-${{ matrix.code-target }}
+          echo "Contents of cli-artifact-${{ matrix.code-target }} directory:"
+          ls -R cli-artifact-${{ matrix.code-target }}
 
       # Rust toolchain setup (only needed for WASM part)
       - uses: dtolnay/rust-toolchain@stable
@@ -175,7 +175,6 @@ jobs:
           echo "Binary copied successfully for $CODE_TARGET."
           ls -l "$dest_path"
 
-
       - name: Install Dependencies
         # Install deps in the context of the specific extension package
         run: pnpm install --frozen-lockfile
@@ -185,7 +184,7 @@ jobs:
         # This might be redundant if it doesn't change per target,
         # but safer to run it. Consider optimizing if slow.
         # Run from root to build dependencies correctly.
-        run: pnpm run build
+        run: pnpm run build:release
         working-directory: typescript/
 
       - name: Create dist directory
@@ -194,15 +193,15 @@ jobs:
       - name: Package VSCode Extension for ${{ matrix.code-target }}
         id: package
         run: |
-           PRE_RELEASE_FLAG=""
-           if [[ "${{ inputs.is_release_build }}" == "false" ]]; then
-             PRE_RELEASE_FLAG="--pre-release"
-           fi
-           OUTPUT_FILENAME="dist/baml-${{ matrix.code-target }}.vsix"
-           echo "Packaging for target: ${{ matrix.code-target }}"
-           # Run vsce from the directory containing the extension's package.json
-           npx @vscode/vsce package $PRE_RELEASE_FLAG --target ${{ matrix.code-target }} -o $OUTPUT_FILENAME --no-dependencies
-           echo "vsix_path=$OUTPUT_FILENAME" >> $GITHUB_OUTPUT
+          PRE_RELEASE_FLAG=""
+          if [[ "${{ inputs.is_release_build }}" == "false" ]]; then
+            PRE_RELEASE_FLAG="--pre-release"
+          fi
+          OUTPUT_FILENAME="dist/baml-${{ matrix.code-target }}.vsix"
+          echo "Packaging for target: ${{ matrix.code-target }}"
+          # Run vsce from the directory containing the extension's package.json
+          npx @vscode/vsce package $PRE_RELEASE_FLAG --target ${{ matrix.code-target }} -o $OUTPUT_FILENAME --no-dependencies
+          echo "vsix_path=$OUTPUT_FILENAME" >> $GITHUB_OUTPUT
         working-directory: typescript/vscode-ext/packages
 
       - name: Upload VSIX artifact for ${{ matrix.code-target }}
@@ -227,4 +226,4 @@ jobs:
       #   with:
       #     name: vscode-playground
       #     path: typescript/vscode-ext/packages/web-panel/dist
-      #     if-no-files-found: error
+      #     if-no-files-found: error

engine/language_client_python/src/runtime.rs

@@ -151,7 +151,6 @@ impl BamlRuntime {
             })
             .collect::<Vec<_>>();
 
-        // let collector = collector.map(|c| c.inner.clone());
         pyo3_async_runtimes::tokio::future_into_py(py, async move {
             let (result, _) = baml_runtime
                 .call_function(

engine/language_server/src/server/api/diagnostics.rs

@@ -90,9 +90,10 @@ pub fn publish_session_lsp_diagnostics(
     if !file_url.to_string().contains("baml_src") {
         return Ok(());
     }
+    tracing::info!("publishing diagnostics for {}", file_url);
     let project = session
         .get_or_create_project(&path)
-        .expect("We just ensured the session is valid");
+        .expect("We just ensured the session is valid.");
 
     let diagnostics = project_diagnostics(project.clone());
     for (uri, diagnostics) in diagnostics {

integ-tests/test.baml

@@ -110,7 +110,7 @@ describe('Modular API Tests', () => {
 
   it('modular google gemini', async () => {
     const client = new GoogleGenerativeAI(process.env.GOOGLE_API_KEY!)
-    const model = client.getGenerativeModel({ model: 'gemini-1.5-pro-001' })
+    const model = client.getGenerativeModel({ model: 'gemini-1.5-pro' })
 
     const clientRegistry = new ClientRegistry()
     clientRegistry.setPrimary('Gemini')

integ-tests/typescript/tests/modular.test.ts

@@ -48,10 +48,6 @@
     "clean": {
       "cache": false
     },
-    "baml-client#build": {
-      "dependsOn": ["@gloo-ai/baml-language-server#build"],
-      "outputs": ["out/**"]
-    },
     "baml#vscode:package": {
       "dependsOn": ["baml-client#build"],
       "outputs": ["baml-*.vsix"]