Skip to content

Commit e02c30a

Browse files
authored
Fix fatal log line showing up with publisher not started (#2038)
<!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Commented out fatal log line in `get_publish_channel` in `publisher.rs` to prevent logging when publisher is not started, with a TODO to revisit logic. > > - **Logging**: > - Commented out `baml_log::fatal_once!` in `get_publish_channel` in `publisher.rs` to prevent fatal log when publisher is not started. > - Added TODO comment to revisit logic for cases like missing API key. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=BoundaryML%2Fbaml&utm_source=github&utm_medium=referral)<sup> for 2d96e11. You can [customize](https://app.ellipsis.dev/BoundaryML/settings/summaries) this summary. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
1 parent 2808cbf commit e02c30a

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

‎engine/baml-runtime/src/tracingv2/publisher/publisher.rs‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,10 @@ fn get_publish_channel(
5454
{
5555
let Some(join_handle) = PUBLISHING_TASK.get() else {
5656
if !allow_missing {
57-
baml_log::fatal_once!(
58-
"Tracing publisher not started. Report this bug to the BAML team."
59-
);
57+
// baml_log::fatal_once!(
58+
// "Tracing publisher not started. Report this bug to the BAML team."
59+
// );
60+
// TODO: redo this logic -- we dont start the publisher if there's no api key for example.
6061
}
6162
return None;
6263
};

0 commit comments

Comments
 (0)