Don't allow parameters with checks/asserts (#1689)

Fix #1578 

<!-- ELLIPSIS_HIDDEN -->


----

> [!IMPORTANT]
> Disallow types with checks/asserts as function parameters and update
client files to reflect this change.
> 
>   - **Behavior**:
> - Disallow types with checks/asserts as function parameters in
`functions.rs` by updating `has_checks_nested()` to handle `TypeAliasId`
and `TypeExpId`.
> - Add test `check_in_parameter_type_alias.baml` to verify disallowed
types with checks as parameters.
>   - **Client Updates**:
> - Update function signatures in `async_client.py`, `sync_client.py`,
and `async_client.ts` to remove checks from parameters.
>     - Modify `openapi.yaml` to reflect changes in parameter types.
>   - **Misc**:
> - Rename `visited` to `visited_classes` and add `visited_type_aliases`
in `NestedChecks` struct in `functions.rs`.
> 
> <sup>This description was created by </sup>[<img alt="Ellipsis"
src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=BoundaryML%2Fbaml&utm_source=github&utm_medium=referral)<sup>
for 3902b35. It will automatically
update as commits are pushed.</sup>


<!-- ELLIPSIS_HIDDEN -->

Author: antoniosarosi

engine/baml-lib/baml-core/src/validate/validation_pipeline/validations/functions.rs

@@ -5,7 +5,9 @@ use crate::validate::validation_pipeline::context::Context;
 use internal_baml_diagnostics::{DatamodelError, DatamodelWarning, Span};
 
 use internal_baml_parser_database::TypeWalker;
-use internal_baml_schema_ast::ast::{FieldType, TypeExpId, WithIdentifier, WithName, WithSpan};
+use internal_baml_schema_ast::ast::{
+    FieldType, TypeAliasId, TypeExpId, WithIdentifier, WithName, WithSpan,
+};
 
 use super::types::validate_type;
 
@@ -227,14 +229,16 @@ pub(super) fn has_checks_nested(ctx: &Context<'_>, field_type: &FieldType) -> bo
 
 struct NestedChecks<'c> {
     ctx: &'c Context<'c>,
-    visited: HashSet<TypeExpId>,
+    visited_classes: HashSet<TypeExpId>,
+    visited_type_aliases: HashSet<TypeAliasId>,
 }
 
 impl<'c> NestedChecks<'c> {
     fn new(ctx: &'c Context<'c>) -> Self {
         Self {
             ctx,
-            visited: HashSet::new(),
+            visited_classes: HashSet::new(),
+            visited_type_aliases: HashSet::new(),
         }
     }
 
@@ -249,7 +253,7 @@ impl<'c> NestedChecks<'c> {
             FieldType::Symbol(_, id, ..) => match self.ctx.db.find_type(id) {
                 Some(TypeWalker::Class(class_walker)) => {
                     // Stop recursion when dealing with recursive types.
-                    if !self.visited.insert(class_walker.id) {
+                    if !self.visited_classes.insert(class_walker.id) {
                         return false;
                     }
 
@@ -262,6 +266,14 @@ impl<'c> NestedChecks<'c> {
                             .map_or(false, |ft| self.has_checks_nested(ft))
                     })
                 }
+                Some(TypeWalker::TypeAlias(type_alias_walker)) => {
+                    if !self.visited_type_aliases.insert(type_alias_walker.id) {
+                        return false;
+                    }
+
+                    let resolved = type_alias_walker.resolved();
+                    self.has_checks_nested(resolved)
+                }
                 _ => false,
             },
 

engine/baml-lib/baml/tests/validation_files/functions_v2/check_in_parameter_type_alias.baml

@@ -0,0 +1,21 @@
+// A type alias to a type with a check.
+type MultipleAttrs = int @assert({{ this > 0 }}) @check(gt_ten, {{ this > 10 }})
+
+// That alias is used as a parameter.
+function AliasWithMultipleAttrs(money: MultipleAttrs) -> MultipleAttrs {
+    client "openai/gpt-4o"
+    prompt r#"
+      Return the given integer without additional context:
+
+      {{ money }}
+
+      {{ ctx.output_format }}
+    "#
+}
+
+// error: Error validating: Types with checks are not allowed as function parameters.
+//   -->  functions_v2/check_in_parameter_type_alias.baml:5
+//    | 
+//  4 | // That alias is used as a parameter.
+//  5 | function AliasWithMultipleAttrs(money: MultipleAttrs) -> MultipleAttrs {
+//    | 

integ-tests/baml_src/test-files/functions/output/type-aliases.baml

@@ -57,7 +57,7 @@ function MergeAliasAttributes(money: int) -> MergeAttrs {
     "#
 }
 
-function ReturnAliasWithMergedAttributes(money: Amount) -> Amount {
+function ReturnAliasWithMergedAttributes(money: int) -> Amount {
     client "openai/gpt-4o"
     prompt r#"
       Return the given integer without additional context:
@@ -68,7 +68,7 @@ function ReturnAliasWithMergedAttributes(money: Amount) -> Amount {
     "#
 }
 
-function AliasWithMultipleAttrs(money: MultipleAttrs) -> MultipleAttrs {
+function AliasWithMultipleAttrs(money: int) -> MultipleAttrs {
     client "openai/gpt-4o"
     prompt r#"
       Return the given integer without additional context: