Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please provides test #108

Closed
remicollet opened this issue Mar 29, 2015 · 3 comments

Comments

@remicollet
Copy link
Contributor

commented Mar 29, 2015

Since commit ba719af test suite is no more provided, while useful in downstream distribution,

Please consider reverting this.

@mikey179

This comment has been minimized.

Copy link
Member

commented Mar 31, 2015

Oh my... contradicting targets: small exports vs. providing everything in downstream distributions. I guess @sndsgd did it on purpose, maybe he wants to say something about it.

@sndsgd

This comment has been minimized.

Copy link
Contributor

commented Mar 31, 2015

The changes in ba719af indeed were to create smaller distributions. I assumed that if people wanted to test this library, they'd be working with a clone of the repo, and therefore have everything.

@mikey179 mikey179 closed this in 5c0a71c Oct 6, 2015
@remicollet

This comment has been minimized.

Copy link
Contributor Author

commented Oct 7, 2015

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.