Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to GitHub Actions, implements #215 #219

Merged
merged 10 commits into from Feb 24, 2020
Merged

Conversation

@mikey179
Copy link
Member

mikey179 commented Feb 20, 2020

This PR intends to add the necessary configurations to enable switching from Travis/AppVeyor to GitHub Actions, as proposed with #215.

@mikey179 mikey179 self-assigned this Feb 20, 2020
mikey179 added 2 commits Feb 20, 2020
…cs2pr
@mikey179

This comment has been minimized.

Copy link
Member Author

mikey179 commented Feb 20, 2020

Interesting side note: we can't upgrade to PHPStan 0.12 - it complains about all functions imported from the global namespace that they are deprecated. 😳

mikey179 added 3 commits Feb 20, 2020
Only one PHP version is required, so no build matrix here.

The checkstyle report has to be written into a file, otherwise regular phpcs progress output and checkstyle report are intermingled and cs2pr can't parse this. Therefore, checkstyle report is written into a file and after that cs2pr is executed with that file.
.github/workflows/phpstan.yml Outdated Show resolved Hide resolved
strategy:
fail-fast: false
matrix:
php-versions: ['7.3', '7.4']

This comment has been minimized.

Copy link
@mikey179

mikey179 Feb 20, 2020

Author Member

I left away 7.2 because I think with the next major release of vfsStream the minimum version should be 7.3 as 7.2 is in its retirement phase. Also left away 8.0 as we don't care about it yet - if we start to aim for that one it can be added.

},
"scripts": {
"test": "phpunit",
"php-coveralls": "php-coveralls"
}

This comment has been minimized.

Copy link
@mikey179

mikey179 Feb 20, 2020

Author Member

Added the scripts section so that the scripts in vendor/bin can be executed on Windows as well by using the composer run-script feature.

@mikey179

This comment has been minimized.

Copy link
Member Author

mikey179 commented Feb 20, 2020

I added some comments/questions directly in the diff. Some more common questions that we might want to discuss:

  • In contrast to the phpdocumentor QA workflow example mentioned by @jaapio in #215 I deliberately split the workflow into three separate ones. Even though that includes some duplication the single workflow configurations stay small and are easier to understand from my point of view.

Once we agree on the raised questions (and any other comments/objections you may raise) there's some things to do in this PR before it is ready to merge:

  • remove configuration for Travis and AppVeyor
  • update build status badge in README.md to the new source
.github/workflows/runTests.yml Outdated Show resolved Hide resolved
mikey179 added 4 commits Feb 21, 2020
@mikey179 mikey179 marked this pull request as ready for review Feb 21, 2020
@mikey179 mikey179 requested a review from bovigo/vfsstream Feb 21, 2020
@jaapio
jaapio approved these changes Feb 21, 2020
@jaapio

This comment has been minimized.

Copy link
Contributor

jaapio commented Feb 21, 2020

You will need to disable AppVeyor from the dashboard.

@allejo
allejo approved these changes Feb 23, 2020
@mikey179 mikey179 merged commit 10e92f0 into master Feb 24, 2020
20 of 22 checks passed
20 of 22 checks passed
PHP CodeSniffer
Details
analyse
Details
PHP 7.3 on ubuntu-latest w/ install
Details
PHP 7.3 on ubuntu-latest w/ update --prefer-lowest
Details
PHP 7.3 on ubuntu-latest w/ update
Details
PHP 7.3 on windows-latest w/ install
Details
PHP 7.3 on windows-latest w/ update --prefer-lowest
Details
PHP 7.3 on windows-latest w/ update
Details
PHP 7.3 on macOS-latest w/ install
Details
PHP 7.3 on macOS-latest w/ update --prefer-lowest
Details
PHP 7.3 on macOS-latest w/ update
Details
PHP 7.4 on ubuntu-latest w/ install
Details
PHP 7.4 on ubuntu-latest w/ update --prefer-lowest
Details
PHP 7.4 on ubuntu-latest w/ update
Details
PHP 7.4 on windows-latest w/ install
Details
PHP 7.4 on windows-latest w/ update --prefer-lowest
Details
PHP 7.4 on windows-latest w/ update
Details
PHP 7.4 on macOS-latest w/ install
Details
PHP 7.4 on macOS-latest w/ update --prefer-lowest
Details
PHP 7.4 on macOS-latest w/ update
Details
continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
@mikey179

This comment has been minimized.

Copy link
Member Author

mikey179 commented Feb 24, 2020

Disabled AppVeyor after merge.

@mikey179 mikey179 deleted the feature/github_actions branch Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.