Skip to content

Polymorphic functions docs #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 8, 2020
Merged

Polymorphic functions docs #622

merged 9 commits into from
Oct 8, 2020

Conversation

ferranpujolcamins
Copy link
Contributor

Related issues

#620

truizlop
truizlop requested changes Oct 2, 2020
View reviewed changes
Copy link
Member

@truizlop truizlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I really like the way the topic is introduced, with an example that motivates the usage, how Swift cannot represent this, and how this is addressed in Bow. I have added some minor comments, in some case are nitpicks.

ferranpujolcamins and others added 4 commits October 2, 2020 15:42
@ferranpujolcamins @truizlop
Apply suggestions from code review
d9371b7 
Formatting and spelling mistakes

Co-authored-by: Tomás Ruiz-López <truizlop@gmail.com>
@ferranpujolcamins
Fix example of callTwice function usage
7e83ee5
@ferranpujolcamins @truizlop
Update Documentation.app/Contents/MacOS/FP concepts.playground/Pages/…
be3201b 
…Rank-N polymorphism.xcplaygroundpage/Contents.swift


Fix callTwice example

Co-authored-by: Tomás Ruiz-López <truizlop@gmail.com>
@ferranpujolcamins
Add more detail on the usage of Id and ArrayK
7f55d66
@ferranpujolcamins
Copy link
Contributor Author

Thank you very much for the review, you made good observations! I've addressed them all.

@truizlop truizlop merged commit 210d1cc into bow-swift:master Oct 8, 2020
@truizlop
Copy link
Member

truizlop commented Oct 8, 2020

Looking forward to seeing this deployed in the site!

@truizlop truizlop mentioned this pull request Oct 8, 2020
Closed
@ferranpujolcamins ferranpujolcamins deleted the polymorphicFunctionsDOcs branch October 8, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@truizlop truizlop truizlop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ferranpujolcamins @truizlop