Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`--save` by default #1040

Closed
sindresorhus opened this issue Jan 8, 2014 · 35 comments
Closed

`--save` by default #1040

sindresorhus opened this issue Jan 8, 2014 · 35 comments
Labels

Comments

@sindresorhus
Copy link
Contributor

@sindresorhus sindresorhus commented Jan 8, 2014

Since most people would want to save a dependency to bower.json when doing bower install <package> I suggest we make --save the default and introduce a --no-save flag. The default will only have an effect if there is a bower.json.

@addyosmani
Copy link
Member

@addyosmani addyosmani commented Jan 8, 2014

👍

@xen
Copy link

@xen xen commented Jan 9, 2014

Upvote 👍

@svnlto
Copy link
Member

@svnlto svnlto commented Jan 9, 2014

👍

1 similar comment
@Anahkiasen
Copy link

@Anahkiasen Anahkiasen commented Jan 10, 2014

👍

@sheerun
Copy link
Contributor

@sheerun sheerun commented Jan 10, 2014

Of course this is 2.x feature as it breaks api.

@helmus
Copy link

@helmus helmus commented Jan 18, 2014

👍

1 similar comment
@hemanth
Copy link
Contributor

@hemanth hemanth commented Jan 18, 2014

👍

@wibblymat
Copy link
Member

@wibblymat wibblymat commented Jan 21, 2014

We could add a .bowerrc flag like save-by-default. Default to false now and flip to true for 2.x?

@sindresorhus
Copy link
Contributor Author

@sindresorhus sindresorhus commented Jan 21, 2014

@wibblymat 👍

@gh-naylor
Copy link

@gh-naylor gh-naylor commented Jan 22, 2014

+1

Would it possible to set this to --save to the <head> tag inside a given file? (index.html for example)

@sindresorhus
Copy link
Contributor Author

@sindresorhus sindresorhus commented Jan 22, 2014

@gh-naylor no, that's a task for another tool.

@benschwarz
Copy link
Member

@benschwarz benschwarz commented Jan 23, 2014

👍 To @wibblymat's proposal.
Flip to true for 2.x and then deprecate the .bowerrc option.

@wibblymat
Copy link
Member

@wibblymat wibblymat commented Jan 27, 2014

PRs welcome ;)

wibblymat added a commit to wibblymat/bower that referenced this issue Jan 27, 2014
wibblymat added a commit that referenced this issue Jan 28, 2014
Added a .bowerrc option to make bower install assume --save (#1040)
@ninjatronic
Copy link

@ninjatronic ninjatronic commented Mar 5, 2014

I disagree. The --save option is consistent with other package managers (e.g. npm). Probably this change will be confusing to users.

@kevva
Copy link

@kevva kevva commented Mar 5, 2014

@ninjatronic, component for example is using --saveby default, and that's probably the intended behaviour in most cases, even though npm is not using it.

@benschwarz
Copy link
Member

@benschwarz benschwarz commented Mar 5, 2014

Yeah, I think this is a solid change and we should move in that direction.
I don't care what other package managers do in this instance.

@Anahkiasen
Copy link

@Anahkiasen Anahkiasen commented Mar 5, 2014

Composer saves packages by default, for the note.

@ninjatronic
Copy link

@ninjatronic ninjatronic commented Mar 5, 2014

Worth noting then that uninstall should then also be expected to remove entries from the bower.json file

@fmalk
Copy link

@fmalk fmalk commented Mar 20, 2014

👍

@apfelbox
Copy link

@apfelbox apfelbox commented Apr 15, 2014

👍 (always annoyed that other package managers don't do the same)

@paulirish paulirish added this to the 2.0.0 milestone Apr 15, 2014
@paulirish
Copy link
Member

@paulirish paulirish commented Apr 15, 2014

Added to 2.0 milestone.

We'll need to output some message indicating the bower.json has been updated.

@benschwarz benschwarz modified the milestones: 2.0.0, 1.3.2 Apr 16, 2014
@martinkr
Copy link

@martinkr martinkr commented May 27, 2014

+1

3 similar comments
@chibicode
Copy link
Contributor

@chibicode chibicode commented Jun 8, 2014

👍

@karin-n
Copy link

@karin-n karin-n commented Jun 10, 2014

+1

@yumyo
Copy link

@yumyo yumyo commented Sep 19, 2014

+1

@chuyik
Copy link

@chuyik chuyik commented Oct 11, 2014

+1
How's this going? I think this should be set like npm: npm config set save true

@tannerhodges
Copy link

@tannerhodges tannerhodges commented Jan 16, 2015

👍

@legshooter
Copy link

@legshooter legshooter commented Mar 4, 2015

👍

@automatix
Copy link

@automatix automatix commented Apr 3, 2015

+1 for save_by_default/save_dev_by_default (true|false, default = false) and --no-save/--no-save-dev.

@vedmant
Copy link

@vedmant vedmant commented Jul 26, 2015

👍 I'm for this feature! Often forget to add --save, mostly I install package and want to save it to bower.json. Also I'm for removing .bowerrc and add directory option to bower.json, this really confused me when I learned Bower.

@ohcrider
Copy link

@ohcrider ohcrider commented Sep 1, 2015

👍

@svengt
Copy link

@svengt svengt commented Dec 2, 2015

I would suggest to make this configurable like npm does.

$ npm config set save=true
$ npm config set save-exact=true

http://blog.heroku.com/archives/2015/11/10/node-habits-2016#2-use-a-smart-npmrc

@sheerun
Copy link
Contributor

@sheerun sheerun commented Dec 2, 2015

Good idea. I'll accept a PR enabling it for .bowerrc (with tests).

@benmann
Copy link
Member

@benmann benmann commented Mar 1, 2016

I feel like #2161 is not just a neat solution but also enough to close this issue.
cc: @sheerun agree?

@sheerun
Copy link
Contributor

@sheerun sheerun commented Mar 1, 2016

yup :)

@sheerun sheerun closed this Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
You can’t perform that action at this time.