`--save` by default #1040

Closed
sindresorhus opened this Issue Jan 8, 2014 · 35 comments

Projects

None yet
@sindresorhus
Member

Since most people would want to save a dependency to bower.json when doing bower install <package> I suggest we make --save the default and introduce a --no-save flag. The default will only have an effect if there is a bower.json.

@addyosmani
Member

👍

@xen
xen commented Jan 9, 2014

Upvote 👍

@svnlto
Member
svnlto commented Jan 9, 2014

👍

@Anahkiasen

👍

@sheerun
Collaborator
sheerun commented Jan 10, 2014

Of course this is 2.x feature as it breaks api.

@helmus
helmus commented Jan 18, 2014

👍

@hemanth
hemanth commented Jan 18, 2014

👍

@wibblymat
Member

We could add a .bowerrc flag like save-by-default. Default to false now and flip to true for 2.x?

@sindresorhus
Member

@wibblymat 👍

@gh-naylor

+1

Would it possible to set this to --save to the <head> tag inside a given file? (index.html for example)

@sindresorhus
Member

@gh-naylor no, that's a task for another tool.

@benschwarz
Member

👍 To @wibblymat's proposal.
Flip to true for 2.x and then deprecate the .bowerrc option.

@wibblymat
Member

PRs welcome ;)

@ninjatronic

I disagree. The --save option is consistent with other package managers (e.g. npm). Probably this change will be confusing to users.

@kevva
kevva commented Mar 5, 2014

@ninjatronic, component for example is using --saveby default, and that's probably the intended behaviour in most cases, even though npm is not using it.

@benschwarz
Member

Yeah, I think this is a solid change and we should move in that direction.
I don't care what other package managers do in this instance.

@Anahkiasen

Composer saves packages by default, for the note.

@ninjatronic

Worth noting then that uninstall should then also be expected to remove entries from the bower.json file

@fmalk
fmalk commented Mar 20, 2014

👍

@apfelbox

👍 (always annoyed that other package managers don't do the same)

@paulirish paulirish added this to the 2.0.0 milestone Apr 15, 2014
@paulirish
Member

Added to 2.0 milestone.

We'll need to output some message indicating the bower.json has been updated.

@benschwarz benschwarz modified the milestone: 2.0.0, 1.3.2 Apr 16, 2014
@martinkr

+1

@chibicode

👍

@karin-n
karin-n commented Jun 10, 2014

+1

@yumyo
yumyo commented Sep 19, 2014

+1

@chuyik
chuyik commented Oct 11, 2014

+1
How's this going? I think this should be set like npm: npm config set save true

@tannerhodges

👍

@legshooter

👍

@automatix

+1 for save_by_default/save_dev_by_default (true|false, default = false) and --no-save/--no-save-dev.

@vedmant
vedmant commented Jul 26, 2015

👍 I'm for this feature! Often forget to add --save, mostly I install package and want to save it to bower.json. Also I'm for removing .bowerrc and add directory option to bower.json, this really confused me when I learned Bower.

@fewspider

👍

@svengt
svengt commented Dec 2, 2015

I would suggest to make this configurable like npm does.

$ npm config set save=true
$ npm config set save-exact=true

http://blog.heroku.com/archives/2015/11/10/node-habits-2016#2-use-a-smart-npmrc

@sheerun
Collaborator
sheerun commented Dec 2, 2015

Good idea. I'll accept a PR enabling it for .bowerrc (with tests).

@benmann
Member
benmann commented Mar 1, 2016

I feel like #2161 is not just a neat solution but also enough to close this issue.
cc: @sheerun agree?

@sheerun
Collaborator
sheerun commented Mar 1, 2016

yup :)

@sheerun sheerun closed this Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment