added "Should emit error event" to "info" spec #15

Merged
merged 3 commits into from Sep 13, 2012

5 participants

@wilmoore

No description provided.

@wilmoore wilmoore Added 'info' test
- Should emit error event
164d366
@aeosynth

The Travis build failed

@wilmoore

Likely due to something that was already failing [1) Should resolve JSON dependencies]:

mocha -R spec -t 10000 --grep package

The suite I added to should run successfully:

mocha -R spec -t 10000 --grep info

Unfortunately, there is no way to tell travis that it should only run this delta; further, I did look at the failing test under the "package" suite but was unable to decipher what it was trying to convey; thus, I didn't go any further in trying to fix it.

@NARKOZ

jquery-ui not found

It's called jqueryui here.

@paulirish
Bower member

Lemme fix that pesky error...

@paulirish
Bower member
@NARKOZ

Shouldn't it be changed here: https://github.com/fat/package-bootstrap/blob/master/component.json? Because it's not assertion error.

@paulirish
Bower member
@aeosynth

the best solution is to rename the registered
package.

I thought that wasn't possible what with the no authentication.

@fat

it's possible, it just requires admin nerds

@paulirish
Bower member

travis build is now passing in master.

@aeosynth
@wilmoore

That should be a wrap on this little can of worms I opened :)

@fat

@aeosynth no, just open a ticket and make a good case for it

@fat fat merged commit b43517a into bower:master Sep 13, 2012

1 check passed

Details default The Travis build passed
@sheerun sheerun pushed a commit that referenced this pull request Jun 10, 2016
@reiz reiz Adding validation for package name
Closes #15
d3ccc73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment