Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

added "Should emit error event" to "info" spec #15

Merged
merged 3 commits into from

5 participants

@wilmoore

No description provided.

@wilmoore wilmoore Added 'info' test
- Should emit error event
164d366
@aeosynth

The Travis build failed

@wilmoore

Likely due to something that was already failing [1) Should resolve JSON dependencies]:

mocha -R spec -t 10000 --grep package

The suite I added to should run successfully:

mocha -R spec -t 10000 --grep info

Unfortunately, there is no way to tell travis that it should only run this delta; further, I did look at the failing test under the "package" suite but was unable to decipher what it was trying to convey; thus, I didn't go any further in trying to fix it.

@NARKOZ

jquery-ui not found

It's called jqueryui here.

@paulirish
Owner

Lemme fix that pesky error...

@paulirish
Owner
@NARKOZ

Shouldn't it be changed here: https://github.com/fat/package-bootstrap/blob/master/component.json? Because it's not assertion error.

@paulirish
Owner
@aeosynth

the best solution is to rename the registered
package.

I thought that wasn't possible what with the no authentication.

@fat
Owner

it's possible, it just requires admin nerds

@paulirish
Owner

travis build is now passing in master.

@aeosynth
@wilmoore

That should be a wrap on this little can of worms I opened :)

@fat
Owner

@aeosynth no, just open a ticket and make a good case for it

@fat fat merged commit b43517a into bower:master

1 check passed

Details default The Travis build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Sep 10, 2012
  1. @wilmoore

    Added 'info' test

    wilmoore authored
    - Should emit error event
  2. @wilmoore
  3. @wilmoore
This page is out of date. Refresh to see the latest.
Showing with 8 additions and 1 deletion.
  1. +8 −1 test/info.js
View
9 test/info.js
@@ -12,6 +12,13 @@ describe('info', function () {
assert(info() instanceof events.EventEmitter);
});
+ it('Should emit error event', function (next) {
+ info('no-package-found').on('error', function (error) {
+ assert(!!error);
+ next();
+ });
+ });
+
it('Should emit end event', function (next) {
info('jquery').on('end', function (data) {
assert(!!data);
@@ -33,4 +40,4 @@ describe('info', function () {
});
});
-});
+});
Something went wrong with that request. Please try again.