Fix: Unable to select drawing annotation after saving #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @ConradJChan has signed the CLA. Thanks for the pull request! |
jstoffan
previously approved these changes
Mar 1, 2019
jeremypress
previously approved these changes
Mar 1, 2019
jeremypress
approved these changes
Mar 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue was that when starting a drawing annotation, in
DrawingModeController.drawingStartHandlerwe would register the thread, which would make an entry into the rbush instance for that page, however the location would be of the mouse event point, not the finished drawing boundary. Upon refresh the whole boundary would be available and registered into rbush so clicking at that point wouldn't be a problem.The solution here is to defer
registerThreaduntil we have successfully saved.A change in experience is also that after the drawing annotation is saved, we unmount the popover