From 0093c9316a7d11e115b964163d779e87481f3b83 Mon Sep 17 00:00:00 2001 From: Conrad Chan Date: Mon, 4 Feb 2019 16:17:12 -0800 Subject: [PATCH] Chore: Adding Cypress tests to cover existing functional tests (#912) --- src/index.html | 9 +- src/lib/Controls.js | 4 +- src/lib/PageControls.js | 4 +- src/lib/shell.html | 8 +- src/lib/viewers/doc/DocBaseViewer.js | 1 + src/lib/viewers/media/MediaControls.html | 2 +- .../integration/document/Controls.e2e.test.js | 101 +++++++++ .../sanity/FileOptions.e2e.test.js | 68 ++++++ test/integration/sanity/Header.e2e.test.js | 21 ++ test/integration/sanity/Sanity.e2e.test.js | 8 +- test/support/commands.js | 28 ++- yarn.lock | 196 ++++++++++-------- 12 files changed, 338 insertions(+), 112 deletions(-) create mode 100644 test/integration/document/Controls.e2e.test.js create mode 100644 test/integration/sanity/FileOptions.e2e.test.js create mode 100644 test/integration/sanity/Header.e2e.test.js diff --git a/src/index.html b/src/index.html index c27ef19a8..4d94d29df 100644 --- a/src/index.html +++ b/src/index.html @@ -82,7 +82,7 @@ loadPreview(); } - function loadPreview() { + function loadPreview(options) { var token = localStorage.getItem('token'); var fileid = localStorage.getItem('fileid'); @@ -92,10 +92,11 @@ /* global Box */ var preview = new Box.Preview(); - preview.show(fileid, token, { - container: ".preview-container", - }); + var previewOptions = options || {}; + previewOptions.container = '.preview-container'; + + preview.show(fileid, token, previewOptions); } // Try to load all properties from storage on page load diff --git a/src/lib/Controls.js b/src/lib/Controls.js index 3116c4ed6..349c515d5 100644 --- a/src/lib/Controls.js +++ b/src/lib/Controls.js @@ -33,8 +33,10 @@ class Controls { constructor(container) { this.containerEl = container; - const controlsWrapperEl = this.containerEl.appendChild(document.createElement('div')); + const controlsWrapperEl = document.createElement('div'); controlsWrapperEl.className = 'bp-controls-wrapper'; + controlsWrapperEl.setAttribute('data-testid', 'controls-wrapper'); + this.containerEl.appendChild(controlsWrapperEl); this.controlsEl = controlsWrapperEl.appendChild(document.createElement('div')); this.controlsEl.className = 'bp-controls'; diff --git a/src/lib/PageControls.js b/src/lib/PageControls.js index b9df6fbe1..1b027878e 100644 --- a/src/lib/PageControls.js +++ b/src/lib/PageControls.js @@ -15,8 +15,8 @@ const NEXT_PAGE = 'bp-next-page'; const pageNumTemplate = `
- 1 - + 1 +  /  1
`.replace(/>\s*<'); diff --git a/src/lib/shell.html b/src/lib/shell.html index 67a6c8679..773554553 100644 --- a/src/lib/shell.html +++ b/src/lib/shell.html @@ -8,23 +8,23 @@
- - - -