From 7da7efcf5dd1f3f5323f14323a4bde5c5b0e5823 Mon Sep 17 00:00:00 2001
From: bhh1988 <bhh1988@gmail.com>
Date: Thu, 25 May 2017 15:04:28 -0700
Subject: [PATCH] Update: Make media viewer settings menu larger so scrollbars
 don't show (#149)

Before, scrollbars could show on the various menus depending on your
scrollbar settings (e.g. OS settings, or mouse plugged in). This is
because the menu height was sized based on heights of items inside plus
padding, but forgot about border. Accounting for the 1px border fixes
this issue
---
 src/lib/viewers/media/Settings.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/lib/viewers/media/Settings.js b/src/lib/viewers/media/Settings.js
index 21b978aa8..d871bf50e 100644
--- a/src/lib/viewers/media/Settings.js
+++ b/src/lib/viewers/media/Settings.js
@@ -257,10 +257,10 @@ const SUBTITLES_SUBITEM_TEMPLATE = `<div class="bp-media-settings-sub-item" data
     setMenuContainerDimensions(menu) {
         // NOTE: need to explicitly set the dimensions in order to get css transitions. width=auto doesn't work with css transitions
         this.settingsEl.style.width = `${menu.offsetWidth + 18}px`;
-        // height = n * $item-height + 2 * $padding (see Settings.scss)
+        // height = n * $item-height + 2 * $padding (see Settings.scss) + 2 * border (see Settings.scss)
         // where n is the number of displayed items in the menu
         const sumHeight = [].reduce.call(menu.children, (sum, child) => sum + child.offsetHeight, 0);
-        this.settingsEl.style.height = `${sumHeight + 16}px`;
+        this.settingsEl.style.height = `${sumHeight + 18}px`;
     }
 
     /**