Change downscope_token() to return a TokenResponse object #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @anthonywee has signed the CLA. Thanks for the pull request! |
- Add a TokenResponse object, which is a subclass of BaseAPIJSONObject. - OAuth2.downscope_token() now returns a TokenResponse object, which allows users to get other fields of the response, such as 'expires_in'.
anthonywee
force-pushed
the
downscope_expires_in
branch
from
4e0a956 to
e90a22a
Compare
jmoldow
reviewed
Sep 16, 2017
boxsdk/auth/oauth2.py
Outdated
|
|
||
| access_token, _ = self._send_token_request_without_storing_tokens(data, access_token, expect_refresh_token=False) | ||
| return access_token | ||
| token_response = self.execute_token_request(data, access_token, expect_refresh_token=False) |
boxsdk/auth/oauth2.py
Outdated
| self._access_token, self._refresh_token = access_token, refresh_token | ||
|
|
||
| def _send_token_request_without_storing_tokens(self, data, access_token, expect_refresh_token=True): | ||
| def execute_token_request(self, data, access_token, expect_refresh_token=True): |
Contributor
There was a problem hiding this comment.
I think we should keep this private for now.
Not that I think it should never be public. But until we know that we definitely need this in the public API, I don't think we should clutter the API and add more backwards-compatibility restrictions for ourselves.
Jeff-Meadows
approved these changes
Sep 16, 2017
Contributor
Jeff-Meadows
left a comment
Jeff-Meadows
left a comment
There was a problem hiding this comment.
don't forget to bump the version if you'd like this to be released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows users to get other fields of the response, such as
'expires_in'.