Skip to content

feat: use getDiscriminatorsForUnion in generic serialization (box/box-codegen#448) #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2024
Merged

feat: use getDiscriminatorsForUnion in generic serialization (box/box-codegen#448) #95

merged 2 commits into from
Mar 25, 2024

Conversation

@box-sdk-build
Copy link
Contributor

@box-sdk-build box-sdk-build commented Mar 14, 2024

No description provided.

@coveralls
Copy link

coveralls commented Mar 14, 2024

Pull Request Test Coverage Report for Build 8287132596

Details

  • 347 of 405 (85.68%) changed or added relevant lines in 17 files are covered.
  • 187 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+1.9%) to 43.903%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/schemas.generated.ts 318 376 84.57%
Files with Coverage Reduction New Missed Lines %
src/managers/folderMetadata.generated.ts 1 46.15%
src/networking/fetch.ts 1 80.75%
src/box/jwtAuth.generated.ts 2 80.0%
src/managers/metadataTemplates.generated.ts 3 39.53%
src/managers/fileMetadata.generated.ts 4 46.15%
src/schemas.generated.ts 176 38.38%
Totals Coverage Status
Change from base Build 8228939193: 1.9%
Covered Lines: 7226
Relevant Lines: 12610
💛 - Coveralls

congminh1254
congminh1254 approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@congminh1254 congminh1254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@congminh1254 congminh1254 merged commit 06680c0 into main Mar 25, 2024
@congminh1254 congminh1254 deleted the codegen-530-183c130-b2f7568 branch March 25, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@congminh1254 congminh1254 congminh1254 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@box-sdk-build @coveralls @congminh1254