From 5f8ba11ac88b851c6baa858476e0c6cb3f007182 Mon Sep 17 00:00:00 2001
From: Chris Wilson <chris+github@qwirx.com>
Date: Wed, 3 Aug 2016 22:21:13 +0100
Subject: [PATCH] Add a comment about why we don't "make install" for every
 test.

Change directory using absolute paths for safety and clarity.
---
 runtest.pl.in | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/runtest.pl.in b/runtest.pl.in
index 3cdada571..5ff6647bd 100755
--- a/runtest.pl.in
+++ b/runtest.pl.in
@@ -143,6 +143,9 @@ sub runtest
 			"cmake -E remove_directory $test_dst_dir",
 			"cmake -E copy_directory $test_src_dir $test_dst_dir",
 			"cmake -E copy $test_src_exe $test_dst_dir/$test_dst_exe",
+			# We could do a "make install" here, to ensure that everything
+			# is up to date, but it's really slow, verbose and wasteful:
+			# "cmake --build infrastructure/cmake/build --target install",
 		);
 
 		# Our CMake buildsystem doesn't do anything to support testextra files
@@ -213,7 +216,7 @@ sub runtest
 	{
 		# no tee.exe on Windows, so let's do it ourselves.
 		open LOG, ">$logfile" or die "$logfile: $!";
-		chdir("$test_mode/test/$t");
+		chdir(dirname($0)."/$test_mode/test/$t");
 
 		open TEE, "$test_dst_exe |"
 			or die "$test_dst_dir/$test_dst_exe: $!";
@@ -225,7 +228,7 @@ sub runtest
 		}
 		close LOG;
 		close TEE;
-		chdir("../../..");
+		chdir(dirname($0));
 	}
 	else
 	{