From 93242003b6008f928a115109e174e56f1c0e2213 Mon Sep 17 00:00:00 2001 From: Chris Wilson Date: Mon, 12 Jun 2017 20:46:29 +0100 Subject: [PATCH] Declare Base64 decoding array as signed char Need to use "signed char" explicitly to work around char being unsigned by default on ARM, causing compile errors: https://stackoverflow.com/a/31635045/648162 --- lib/httpserver/cdecode.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/httpserver/cdecode.cpp b/lib/httpserver/cdecode.cpp index e632f1827..57dcc1886 100644 --- a/lib/httpserver/cdecode.cpp +++ b/lib/httpserver/cdecode.cpp @@ -12,7 +12,9 @@ extern "C" int base64_decode_value(char value_in) { - static const char decoding[] = {62,-1,-1,-1,63,52,53,54,55,56,57,58,59,60,61,-1,-1,-1,-2,-1,-1,-1,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,-1,-1,-1,-1,-1,-1,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51}; + // Need to use "signed char" explicitly to work around char being unsigned by default + // on ARM, causing compile errors: https://stackoverflow.com/a/31635045/648162 + static const signed char decoding[] = {62,-1,-1,-1,63,52,53,54,55,56,57,58,59,60,61,-1,-1,-1,-2,-1,-1,-1,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,-1,-1,-1,-1,-1,-1,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51}; static const char decoding_size = sizeof(decoding); value_in -= 43; if (value_in < 0 || value_in > decoding_size) return -1;