Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please support compiling with OpenSSL 1.1 #16

Closed
FauxFaux opened this issue Jun 1, 2017 · 2 comments · Fixed by #22
Closed

Please support compiling with OpenSSL 1.1 #16

FauxFaux opened this issue Jun 1, 2017 · 2 comments · Fixed by #22

Comments

@FauxFaux
Copy link

FauxFaux commented Jun 1, 2017

OpenSSL 1.1 has been out for a while, and is becoming the default on Linux distributions.

It looks like everything works if one uses EVP_CIPHER_CTX *ctx as a pointer, and calls new/free instead of init/cleanup. I didn't test it extensively, beyond letting the test suite run.

The patch against Debian's old version looks like: https://gist.github.com/FauxFaux/8675680985c40d187eff2cf06e8dce70
qris added a commit that referenced this issue Jun 3, 2017
@qris
Add support for OpenSSL 1.1 and replace deprecated function calls
edd3687 
See #16 for details. Thanks to
Chris West @FauxFaux for the initial patch!
@qris
Copy link
Contributor

qris commented Jun 3, 2017 •
edited

Thanks for the message and the patch! Do the regtests really all pass for you with this patch? I'm running into this issue which seems to require non-trivially changing the way that we call EVP_CipherInit(_ex) and the patch doesn't seem to do that. Crypto tests and most other modules fail with exceptions because of this.

@FauxFaux
Copy link
Author

FauxFaux commented Jun 5, 2017

Apparently the package build runs the tests, but ignores their results. Argh, sorry.

I was unaware of the issue you linked, and was relying on test suites, which has gone terribly poorly.

https://sources.debian.net/src/boxbackup/0.11.1~r2837-4/debian/rules/#L34

qris added a commit that referenced this issue Jun 6, 2017
@qris
Add support for OpenSSL 1.1 and replace deprecated function calls (WIP)
b003e00 
See #16 for details. Thanks to
Chris West @FauxFaux for the initial patch!
qris added a commit that referenced this issue Jan 1, 2018
@qris
Add support for OpenSSL 1.1 and replace deprecated function calls
4e28f08 
See #16 for details. Thanks to
Chris West @FauxFaux for the initial patch!

Use OpenSSL 1.1.0g for Windows superbuild.

Fix Windows build by removing calls to obsolete do_ms.bat
<https://stackoverflow.com/questions/39076244/why-there-is-no-ms-do-ms-bat-after-perl-configure-vc-win64a/39247560#39247560>.

Workaround for incorrect library suffixes searched by FindOpenSSL
<https://gitlab.kitware.com/cmake/cmake/issues/17604>.

(cherry picked from commit edd3687)
(cherry picked from commit b003e00)
(cherry picked from commit cc6e204)
(cherry picked from commit 303c640)
(cherry picked from commit 4e24006)
(cherry picked from commit 448ac48)
@qris qris mentioned this issue Jan 1, 2018
Merged
qris added a commit that referenced this issue Jan 1, 2018
@qris
Add support for OpenSSL 1.1 and replace deprecated function calls
85e7efc 
See #16 for details. Thanks to
Chris West @FauxFaux for the initial patch!

Use OpenSSL 1.1.0g for Windows superbuild.

Fix Windows build by removing calls to obsolete do_ms.bat
<https://stackoverflow.com/questions/39076244/why-there-is-no-ms-do-ms-bat-after-perl-configure-vc-win64a/39247560#39247560>.

Workaround for incorrect library suffixes searched by FindOpenSSL
<https://gitlab.kitware.com/cmake/cmake/issues/17604>.

Link OpenSSL statically and fix missing dependency on crypt32.lib.

(cherry picked from commit edd3687)
(cherry picked from commit b003e00)
(cherry picked from commit cc6e204)
(cherry picked from commit 303c640)
(cherry picked from commit 4e24006)
(cherry picked from commit 448ac48)
(cherry picked from commit 00b3bb0)
@qris qris closed this as completed in #22 Jan 2, 2018
qris added a commit that referenced this issue Jan 13, 2018
@qris
Add support for OpenSSL 1.1 and replace deprecated function calls
d1f446e 
See #16 for details. Thanks to
Chris West @FauxFaux for the initial patch!

Use OpenSSL 1.1.0g for Windows superbuild.

Fix Windows build by removing calls to obsolete do_ms.bat
<https://stackoverflow.com/questions/39076244/why-there-is-no-ms-do-ms-bat-after-perl-configure-vc-win64a/39247560#39247560>.

Workaround for incorrect library suffixes searched by FindOpenSSL
<https://gitlab.kitware.com/cmake/cmake/issues/17604>.

Link OpenSSL statically and fix missing dependency on crypt32.lib.

(cherry picked from commit edd3687)
(cherry picked from commit b003e00)
(cherry picked from commit cc6e204)
(cherry picked from commit 303c640)
(cherry picked from commit 4e24006)
(cherry picked from commit 448ac48)
(cherry picked from commit 00b3bb0)
(cherry picked from commit 85e7efc)
qris added a commit that referenced this issue Jan 13, 2018
@qris
Add support for OpenSSL 1.1 and replace deprecated function calls
20f64fb 
See #16 for details. Thanks to
Chris West @FauxFaux for the initial patch!

Use OpenSSL 1.1.0g for Windows superbuild.

Fix Windows build by removing calls to obsolete do_ms.bat
<https://stackoverflow.com/questions/39076244/why-there-is-no-ms-do-ms-bat-after-perl-configure-vc-win64a/39247560#39247560>.

Workaround for incorrect library suffixes searched by FindOpenSSL
<https://gitlab.kitware.com/cmake/cmake/issues/17604>.

Link OpenSSL statically and fix missing dependency on crypt32.lib.

(cherry picked from commit edd3687)
(cherry picked from commit b003e00)
(cherry picked from commit cc6e204)
(cherry picked from commit 303c640)
(cherry picked from commit 4e24006)
(cherry picked from commit 448ac48)
(cherry picked from commit 00b3bb0)
(cherry picked from commit 85e7efc)
qris added a commit that referenced this issue Jan 14, 2018
@qris
Add support for OpenSSL 1.1 and replace deprecated function calls
9840962 
See #16 for details. Thanks to
Chris West @FauxFaux for the initial patch!

Use OpenSSL 1.1.0g for Windows superbuild.

Fix Windows build by removing calls to obsolete do_ms.bat
<https://stackoverflow.com/questions/39076244/why-there-is-no-ms-do-ms-bat-after-perl-configure-vc-win64a/39247560#39247560>.

Workaround for incorrect library suffixes searched by FindOpenSSL
<https://gitlab.kitware.com/cmake/cmake/issues/17604>.

Link OpenSSL statically and fix missing dependency on crypt32.lib.

(cherry picked from commit edd3687)
(cherry picked from commit b003e00)
(cherry picked from commit cc6e204)
(cherry picked from commit 303c640)
(cherry picked from commit 4e24006)
(cherry picked from commit 448ac48)
(cherry picked from commit 00b3bb0)
(cherry picked from commit 85e7efc)
qris added a commit that referenced this issue Jan 14, 2018
@qris
Add support for OpenSSL 1.1 and replace deprecated function calls
36519d7 
See #16 for details. Thanks to
Chris West @FauxFaux for the initial patch!

Use OpenSSL 1.1.0g for Windows superbuild.

Fix Windows build by removing calls to obsolete do_ms.bat
<https://stackoverflow.com/questions/39076244/why-there-is-no-ms-do-ms-bat-after-perl-configure-vc-win64a/39247560#39247560>.

Workaround for incorrect library suffixes searched by FindOpenSSL
<https://gitlab.kitware.com/cmake/cmake/issues/17604>.

Link OpenSSL statically and fix missing dependency on crypt32.lib.

(cherry picked from commit edd3687)
(cherry picked from commit b003e00)
(cherry picked from commit cc6e204)
(cherry picked from commit 303c640)
(cherry picked from commit 4e24006)
(cherry picked from commit 448ac48)
(cherry picked from commit 00b3bb0)
(cherry picked from commit 85e7efc)
(cherry picked from commit 9840962)
qris added a commit that referenced this issue Jan 14, 2018
@qris
Add support for OpenSSL 1.1 and replace deprecated function calls
e5c859b 
See #16 for details. Thanks to
Chris West @FauxFaux for the initial patch!

Use OpenSSL 1.1.0g for Windows superbuild.

Fix Windows build by removing calls to obsolete do_ms.bat
<https://stackoverflow.com/questions/39076244/why-there-is-no-ms-do-ms-bat-after-perl-configure-vc-win64a/39247560#39247560>.

Workaround for incorrect library suffixes searched by FindOpenSSL
<https://gitlab.kitware.com/cmake/cmake/issues/17604>.

Link OpenSSL statically and fix missing dependency on crypt32.lib.

(cherry picked from commit edd3687)
(cherry picked from commit b003e00)
(cherry picked from commit cc6e204)
(cherry picked from commit 303c640)
(cherry picked from commit 4e24006)
(cherry picked from commit 448ac48)
(cherry picked from commit 00b3bb0)
(cherry picked from commit 85e7efc)
qris added a commit that referenced this issue Jan 14, 2018
@qris
Add support for OpenSSL 1.1 and replace deprecated function calls
451d744 
See #16 for details. Thanks to
Chris West @FauxFaux for the initial patch!

Use OpenSSL 1.1.0g for Windows superbuild.

Fix Windows build by removing calls to obsolete do_ms.bat
<https://stackoverflow.com/questions/39076244/why-there-is-no-ms-do-ms-bat-after-perl-configure-vc-win64a/39247560#39247560>.

Workaround for incorrect library suffixes searched by FindOpenSSL
<https://gitlab.kitware.com/cmake/cmake/issues/17604>.

Link OpenSSL statically and fix missing dependency on crypt32.lib.

(cherry picked from commit edd3687)
(cherry picked from commit b003e00)
(cherry picked from commit cc6e204)
(cherry picked from commit 303c640)
(cherry picked from commit 4e24006)
(cherry picked from commit 448ac48)
(cherry picked from commit 00b3bb0)
(cherry picked from commit 85e7efc)
(cherry picked from commit 9840962)
qris added a commit that referenced this issue Jan 14, 2018
@qris
Add support for OpenSSL 1.1 and replace deprecated function calls
7a09c89 
See #16 for details. Thanks to
Chris West @FauxFaux for the initial patch!

Use OpenSSL 1.1.0g for Windows superbuild.

Fix Windows build by removing calls to obsolete do_ms.bat
<https://stackoverflow.com/questions/39076244/why-there-is-no-ms-do-ms-bat-after-perl-configure-vc-win64a/39247560#39247560>.

Workaround for incorrect library suffixes searched by FindOpenSSL
<https://gitlab.kitware.com/cmake/cmake/issues/17604>.

Link OpenSSL statically and fix missing dependency on crypt32.lib.

(cherry picked from commit edd3687)
(cherry picked from commit b003e00)
(cherry picked from commit cc6e204)
(cherry picked from commit 303c640)
(cherry picked from commit 4e24006)
(cherry picked from commit 448ac48)
(cherry picked from commit 00b3bb0)
(cherry picked from commit 85e7efc)
(cherry picked from commit 9840962)
qris added a commit that referenced this issue Jan 15, 2018
@qris
Add support for OpenSSL 1.1 and replace deprecated function calls
32352ce 
See #16 for details. Thanks to
Chris West @FauxFaux for the initial patch!

Use OpenSSL 1.1.0g for Windows superbuild.

Fix Windows build by removing calls to obsolete do_ms.bat
<https://stackoverflow.com/questions/39076244/why-there-is-no-ms-do-ms-bat-after-perl-configure-vc-win64a/39247560#39247560>.

Workaround for incorrect library suffixes searched by FindOpenSSL
<https://gitlab.kitware.com/cmake/cmake/issues/17604>.

Link OpenSSL statically and fix missing dependency on crypt32.lib.

(cherry picked from commit edd3687)
(cherry picked from commit b003e00)
(cherry picked from commit cc6e204)
(cherry picked from commit 303c640)
(cherry picked from commit 4e24006)
(cherry picked from commit 448ac48)
(cherry picked from commit 00b3bb0)
(cherry picked from commit 85e7efc)
jamesog added a commit to boxbackup/packer that referenced this issue Feb 25, 2018
@jamesog
Debian 9: Separate images for libssl 1.0 and 1.1
11aede8 
Stretch uses libssl 1.1 by default. Box currently doesn't compile with
1.1 (GitHub issue boxbackup/boxbackup#16).

libssl 1.0 is available as a separate package - replacing libssl-dev, so
this creates two AMIs, one for each libssl version.

As part of this we need to use separate usernames for Buildbot. Packer
allows specifying a name value to each builder, so we use that builder
name as the Buildbot name. This requires passing the PACKER_BUILD_NAME
environment variable around.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix compatibility with OpenSSL 1.1 boxbackup/boxbackup
2 participants
@FauxFaux @qris