Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add repohost to config.rb #58

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

tpetr commented Feb 20, 2013

Starts paving the way for configurable git repo hosts (ex. for the people using github enterprise). Related to boxen/puppet-boxen#8. Let me know if I'm a bonehead and there's a better way to do this. :-)

Thanks!

/cc @jbarnette

Contributor

mdelagrange commented Feb 20, 2013

I'm looking at similar problems. GitHub Enterprise can run in non-SSL mode, so you might want to do the full URL to the repo instead (e.g. "http(s)://gh.<your_company>.com"). Is there a corresponding PR for puppet-boxen?

tpetr commented Feb 20, 2013

@mdelagralfo yeah being able to specify the entire clone url (or at least protocol + host + repo as separate config values) would be ideal for me too. i don't have a PR open in puppet-boxen yet, but i can do it sometime today

Contributor

mdelagrange commented Feb 20, 2013

I'm working on a PR that may do the job. I'll try to post something today as well.

@tpetr tpetr referenced this pull request in boxen/puppet-boxen Feb 20, 2013

Closed

use boxen::config::repohost instead of github.com when cloning #10

tpetr commented Feb 21, 2013

@mdelagralfo any progress on your end? the more i think about it, the more i want to be able to specify the protocol to clone with as well, which make me feel like just adding repohost isn't the way to go

Contributor

jbarnette commented Feb 21, 2013

What I'd really like to see is a BOXEN_REPO_URL_TEMPLATE env var or something similar. e.g.,

export BOXEN_REPO_URL_TEMPLATE="https://github.com/%s" # or
export BOXEN_REPO_URL_TEMPLATE="git@github.com:%s.git

...with an HTTPS default.

tpetr commented Feb 21, 2013

@jbarnette ahh good call.

Contributor

jbarnette commented Feb 21, 2013

@tpetr Dat generalization.

bhuga commented Feb 21, 2013

👍 to this generalization as long as the 80+ public shareable modules under boxen/boxen never assume a short form. Probably best to make sure that public modules don't make assumptions now, early.

Contributor

jbarnette commented Feb 21, 2013

@bhuga Good call. Pretty sure we don't do any bare repo cloning in the core boxen/puppet-* modules, but it's pretty easy to audit.

Contributor

jbarnette commented Feb 21, 2013

@bhuga grep -r github/ . | grep -v bundle says we're good.

tpetr commented Feb 21, 2013

@jbarnette @bhuga i'll shoot you guys a new PR for BOXEN_REPO_URL_TEMPLATE in the morning, thanks!

@tpetr tpetr closed this Feb 21, 2013

Contributor

jbarnette commented Feb 21, 2013

@tpetr 🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment