install rprojroot as part of install process?

[nmalizia]

Hey sir! Wondering if it's possible to set it up so the library installs rprojroot as part of the install process. I didn't have it installed and as such it popped an error for me.

[boxuancui]

Do you remember when it happened? When installing the package or when loading the package, or when you call specific functions?

[nmalizia]

Great question - I believe it was at initial import, not 100% sure though.

…

On Wed, Dec 7, 2016 at 4:03 PM, Boxuan Cui ***@***.***> wrote: Do you remember when it happened? When installing the package or when loading the package, or when you call specific functions? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#35 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAtpBaYbOfP9gktXxoBDc6TIFeWw-2Ucks5rFx8dgaJpZM4LHDxi> .

[boxuancui]

I need to reproduce the error, so could you do the following?

1. Remove rprojroot and DataExplorer package if you have already installed it.
2. Type R.version and sessionInfo() and paste the output here.
3. Install DataExplorer package again, and paste the exact error message here.

This should not happen, because rprojroot is listed as one of the imports in rmarkdown, according to the DESCRIPTION file (line 3 item 11): https://cran.r-project.org/web/packages/rmarkdown/index.html.

If you are using Rstudio for package installation, could you also make sure you have checked the Install dependencies box?

If you are doing from console, could you make sure it is something like this?

install.packages("DataExplorer", dependencies = TRUE)

[boxuancui]

After some thoughts, let me guess what happened. You installed either rmarkdown or sparklyr at first, then removed rprojroot manually afterwards. Is this true?

If it is, I don't think this is something a package could control. You have to either re-install the reverse dependencies (revere imports) with dependencies = TRUE or install the missing dependency (rprojroot in this case) manually.

Let me know.

[boxuancui]

I have added rprojroot to Suggests, so it should automatically install it without error. We will see when it is released to CRAN. Please re-open if this doesn't fix it.

[nmalizia]

OK, sorry for my radio silence. I was working off a fresh install of 3. something. I'll try to install it on another EC2 and see if it creates an error. Thanks man - this library is cool!

…

On Tue, Dec 13, 2016 at 11:26 AM, Boxuan Cui ***@***.***> wrote: Closed #35 <#35>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#35 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAtpBRGJPUvBmvwSwTeGSpuHFDOtqPbgks5rHscygaJpZM4LHDxi> .

[boxuancui]

You might want to do devtools::install_github("boxuancui/DataExplorer", ref = "develop") since it is only available in the develop branch.

[boxuancui]

I recall my previous previous comment. Putting it in Suggests does not fix it. However, I believe I find the true cause. In my DESCRIPTION file, it was importing rmarkdown 0.9.5, but rprojroot package was added to the NAMESPACE after that version. So, I changed 0.9.5 to current version, and it should fix that problem, for real this time.

[nmalizia]

Thanks dude!

…

On Tue, Dec 13, 2016 at 12:58 PM, Boxuan Cui ***@***.***> wrote: I recall my previous previous comment. Putting it in Suggests does not fix it. However, I believe I find the true cause. In my DESCRIPTION file, it was importing rmarkdown 0.9.5, but rprojroot package was added to the NAMESPACE after that version. So, I changed 0.9.5 to current version, and it should fix that problem, for real this time. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#35 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAtpBfW7vCK1f4jgMKRj_9vcqKehycYvks5rHtyugaJpZM4LHDxi> .