Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes to plots #56

Closed
amrrs opened this issue Feb 14, 2018 · 6 comments
Closed

Themes to plots #56

amrrs opened this issue Feb 14, 2018 · 6 comments

Comments

@amrrs
Copy link

@amrrs amrrs commented Feb 14, 2018

Is it possible to add themes to existing plot outputs?

@boxuancui
Copy link
Owner

@boxuancui boxuancui commented Feb 14, 2018

Do you mean these?

@holgerbrandl
Copy link

@holgerbrandl holgerbrandl commented Feb 14, 2018

Along with that: theming should be consistent between plots. Currently boxplots are using the default ggplot2 theme, but barplots do not.

@sugang
Copy link

@sugang sugang commented Mar 22, 2018

I also recommend adding a parameter to let users specify the size of fonts. For plot_missing on large datasets the axis and label texts are barely legible. Actually I feel it would be more useful to return the chart than return the data table so that users may do additional processing w/ the charts

@boxuancui
Copy link
Owner

@boxuancui boxuancui commented Mar 22, 2018

@sugang Do you mind creating a separate issue for your comment? While this issue should be a quick fix, your suggestion might require some major infrastructure change. I do not want to lose sight of it, and I need to think about it a little. Thanks!

@boxuancui boxuancui self-assigned this Mar 22, 2018
@boxuancui boxuancui added this to the 0.6.0 milestone Mar 22, 2018
@boxuancui
Copy link
Owner

@boxuancui boxuancui commented Mar 22, 2018

@sugang While I use theme_set() to resolve this issue, I will try to include theme_update() or theme_replace() to allow changes to individual elements, e.g., font size.

@sugang
Copy link

@sugang sugang commented Mar 23, 2018

Sure. I check the source code and the values are fixed at the moment. I have some other recommendations, will create tickets.

boxuancui added a commit that referenced this issue Mar 27, 2018
@boxuancui boxuancui closed this Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.